Skip to content

Fix missing space between block and inline sibling elements in JSoupTextExtractor #1926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnioche merged 2 commits into from
Jun 3, 2026
Merged

Fix missing space between block and inline sibling elements in JSoupTextExtractor #1926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79fa999
Fix missing space between block and inline sibling elements in JSoupT…
nicoscandolo Jun 2, 2026
2b3d08f
Address review: anonymize test data and update tail() comment
nicoscandolo Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/main/java/org/apache/stormcrawler/parse/JSoupTextExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,14 +139,14 @@ public void head(Node node, int depth) {

public void tail(Node node, int depth) {
// make sure there is a space between block tags and immediately
// following text nodes <div>One</div>Two should be "One Two".
// following siblings <div>One</div><a>Two</a> should be "One Two".
if (node instanceof Element) {
Element element = (Element) node;
if (element == excluded) {
excluded = null;
}
if (element.isBlock()
&& (node.nextSibling() instanceof TextNode)
&& node.nextSibling() != null
&& !lastCharIsWhitespace(accum)) {
accum.append(' ');
}
Expand Down
29 changes: 29 additions & 0 deletions core/src/test/java/org/apache/stormcrawler/parse/JSoupTextExtractorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,35 @@ void testExclusionCase() throws IOException {
assertEquals("the content of the page", text);
}

@Test
void testBlockFollowedByInlineElement() {
Config conf = new Config();
JSoupTextExtractor extractor = new JSoupTextExtractor(conf);
// block element followed by an inline anchor — see #1925
String content =
"<html><body><div>"
+ "<h3>Contact</h3>"
+ "<a href=\"mailto:info@example.com\">info@example.com</a>"
+ "</div></body></html>";
Document jsoupDoc = Parser.htmlParser().parseInput(content, "http://example.com");
String text = extractor.text(jsoupDoc.body());
assertEquals("Contact info@example.com", text);
}

@Test
void testBlockFollowedByInlineSpan() {
Config conf = new Config();
JSoupTextExtractor extractor = new JSoupTextExtractor(conf);
String content =
"<html><body><div>"
+ "<div>Phone</div>"
+ "<span>555-0100</span>"
+ "</div></body></html>";
Document jsoupDoc = Parser.htmlParser().parseInput(content, "http://example.com");
String text = extractor.text(jsoupDoc.body());
assertEquals("Phone 555-0100", text);
}

@Test
void testTrimContent() throws IOException {
Config conf = new Config();
Expand Down