Skip to content

RATIS-2570. Minor improvements in make_rc.sh#1491

Merged
adoroszlai merged 6 commits into
apache:masterfrom
adoroszlai:RATIS-2570
Jun 26, 2026
Merged

RATIS-2570. Minor improvements in make_rc.sh#1491
adoroszlai merged 6 commits into
apache:masterfrom
adoroszlai:RATIS-2570

Conversation

@adoroszlai

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Make some minor improvements in make_rc.sh:

  • print actual release version, not snapshot one
  • check GPG key sooner
  • merge 3 loops over *.tar.gz
  • skip empty commit
  • fix typos

https://issues.apache.org/jira/browse/RATIS-2570

How was this patch tested?

Before:

Prepare release artifacts for Apache Ratis 3.3.0-SNAPSHOT

After:

Prepare release artifacts for Apache Ratis 0.0.1-ci-test

Tested that creating two subsequent RCs does not add empty versioning commits:

Prepare release artifacts for Apache Ratis 0.0.1-rc2
...
++ git commit -a -m '[RELEASE] Update version to 0.0.1'
On branch release-0.0.1
nothing to commit, working tree clean
++ echo '<version> up to date, nothing to commit'
<version> up to date, nothing to commit
...
HEAD is now at a8758c5f [RELEASE] Update version to 0.0.1
...

release check in CI:
https://github.com/adoroszlai/ratis/actions/runs/28117851656/job/83261844311

@adoroszlai adoroszlai self-assigned this Jun 24, 2026

@szetszwo szetszwo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 the change looks good.

@adoroszlai adoroszlai merged commit 4804493 into apache:master Jun 26, 2026
18 checks passed
@adoroszlai adoroszlai deleted the RATIS-2570 branch June 26, 2026 09:17
@adoroszlai

Copy link
Copy Markdown
Contributor Author

Thanks @szetszwo for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants