RANGER-5647: Fix remaining ISO EXPIRES_ON dates in hive tag tests#1021
Merged
Merged
Conversation
PR apache#1018 updated slash-format tag fixture dates to 2099/12/31 but left 2026-06-15 ISO expiry_date values in test_policyengine_tag_hive.json. After 2026-06-15, TestPolicyEngine.testPolicyEngine_hiveForTag fails CI with isAllowed expected true but was false for EXPIRES_ON SELF match. Co-authored-by: Cursor <cursoragent@cursor.com>
ramackri
requested review from
kumaab,
mneethiraj,
pradeepagrawal8184 and
vikaskr22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes RANGER-5647 / #1018 for ISO-format tag expiry dates in policy-engine tests.
PR #1018 changed slash-format fixture dates (
2026/06/15→2099/12/31) in shared tag JSON files andRangerPathResourceMatcherthread safety. Two inline ISOEXPIRES_ONvalues intest_policyengine_tag_hive.jsonwere left unchanged.After 2026-06-15, CI
build-17fails:Tag policy uses
ctx.isAccessedAfter('expiry_date'); once the clock passes the fixture expiry, access is denied.Changes
agents-common/src/test/resources/policyengine/test_policyengine_tag_hive.json2026-06-15T15:05:15.000Z→2099-12-31T15:05:15.000Zfor EXPIRES_ON DESCENDANT and SELF test casesNo policy-engine logic changes — test fixture dates only.
Related
Test plan
mvn test -pl agents-common -Dtest=TestPolicyEngine#testPolicyEngine_hiveForTag,TestPolicyEngine#testPolicyEngine_hiveForTag_filebased -Drat.skip=true -Dcheckstyle.skip=true -Dpmd.skip=true -Dspotbugs.skip=true