1wire: Move onewire_valid_rom to 1wire_crc.h#19216
Open
ghnotgood wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
Area: Drivers
|
xiaoxiang781216
approved these changes
Jun 25, 2026
Contributor
|
@michael-membrowse Please fix job [analyze (stm32-nucleo-f103rb, nucleo-f103rb:nsh, nuttx, boards/arm/stm32/nucleo-f103rb/scripts/ld.script]
https://github.com/apache/nuttx/actions/runs/28171450180/job/83436526606?pr=19216#logs new path |
Contributor
|
@simbit18 please rebase, the fix was already pushed |
Contributor
|
@ghnotgood please rebase |
To let developers use all procedures implemented in the corresponding .c file when 1wire_crc.h is included. Signed-off-by: Jiri Vlasak <jvlasak@elektroline.cz>
michallenc
approved these changes
Jun 26, 2026
xiaoxiang781216
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To let developers use all procedures implemented in the corresponding .c file when 1wire_crc.h is included.
Summary
When
nuttx/1wire/1wire_crc.his included, all the procedures implemented in thedrivers/1wire/1wire_crc.call available exceptonewire_valid_rom.Impact
onewire_valid_romwill be available after#include <nuttx/1wire/1wire_crc.h>.Testing
I have compiled the NuttX with the custom implementation of 1wire protocol that uses
onewire_valid_romand sucessfuly used it.I have not tested this on a board where 1wire is used. Could anyone, please, do it? It looks
onewire_valid_romis used only indrivers/1wire/1wire.candis a part of this PR, but better save than sorry. Thanks!