Restore buildConfiguration() callback in deprecated PluginDescriptorBuilder.build() methods#11869
Merged
Conversation
The MNG-7947 refactoring changed the deprecated build(Reader, String) and build(InputStream, String) methods to delegate to the new build(ReaderSupplier/StreamSupplier, String) methods, which bypassed the overridable buildConfiguration() method. This broke subclasses (such as EnhancedPluginDescriptorBuilder in maven-plugin-tools) that override buildConfiguration() to intercept the parsed configuration. Restore the buildConfiguration() callback in the legacy code path while still supporting PLUGIN 2.0.0 namespace detection. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
rmannibucau
approved these changes
May 19, 2026
|
@gnodet Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildConfiguration()callback in the deprecatedbuild(Reader, String)andbuild(InputStream, String)methodsEnhancedPluginDescriptorBuilderin maven-plugin-toolsbuildConfiguration()for the legacy formatContext
This fixes the root cause of apache/maven-plugin-tools#806 and unblocks apache/maven-plugin-tools#1091 (Maven 4 CI).
The
build(Reader, String)method was changed from:to:
which skips the
buildConfiguration()callback entirely. Subclasses that overridebuildConfiguration()to intercept the parsed configuration (e.g., to extractrequiredJavaVersion) get a null field and NPE.Test plan
mvn compile testpasses incompat/maven-plugin-api🤖 Generated with Claude Code