Skip to content

Clean up AbstractDependencyMojoTestCase setUp#1490

Merged
slachiewicz merged 1 commit into
apache:masterfrom
Ndacyayisenga-droid:testfix
Aug 22, 2025
Merged

Clean up AbstractDependencyMojoTestCase setUp#1490
slachiewicz merged 1 commit into
apache:masterfrom
Ndacyayisenga-droid:testfix

Conversation

@Ndacyayisenga-droid

@Ndacyayisenga-droid Ndacyayisenga-droid commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

Following this checklist to help us incorporate your
contribution quickly and easily:

Fixes #1486

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@olamy olamy changed the title [MDEP-979] Clean up AbstractDependencyMojoTestCase setUp Issue #1486 Clean up AbstractDependencyMojoTestCase setUp Jun 26, 2025
@elharo elharo changed the title Issue #1486 Clean up AbstractDependencyMojoTestCase setUp Clean up AbstractDependencyMojoTestCase setUp Jun 26, 2025
@elharo
elharo self-requested a review June 26, 2025 12:04
@olamy olamy added the skip-changelog Skip this PR from automatically changelog generation label Jun 27, 2025

@elharo elharo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one needs the ICKA signed or a commitment to license under apache with the checkbox, or something

@olamy

olamy commented Jul 29, 2025

Copy link
Copy Markdown
Member

I think this one needs the ICKA signed or a commitment to license under apache with the checkbox, or something

Not sure as most of the code is for src/test/.
But why not ICLA if @Ndacyayisenga-droid is happy to do it. See here https://www.apache.org/licenses/contributor-agreements.html#submitting

@slachiewicz
slachiewicz merged commit 9bdfecf into apache:master Aug 22, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Skip this PR from automatically changelog generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MDEP-979] Clean up AbstractDependencyMojoTestCase setUp

4 participants