Skip to content

fix(desktop): retry update downloads without rechecking feed - #5642

Open
jackwener wants to merge 1 commit into
apache:mainfrom
jackwener:codex/update-reliability
Open

jackwener wants to merge 1 commit into
apache:mainfrom
jackwener:codex/update-reliability

Conversation

@jackwener

Copy link
Copy Markdown
Member

Summary

  • Retry a failed background asset download once after a short delay, without repeating the GitHub release-feed request.
  • Make manual download retry reuse electron-updater's already discovered update and route the About-page action to that retry path.
  • Keep provenance verification and install gating in place; add bounded diagnostic messages and regression coverage for retry success, final failure, and Nightly versions.

Verification

  • npm --workspace @maka/desktop run build
  • npx tsc -p apps/desktop/tsconfig.renderer.json --noEmit
  • 47 focused App Update tests passed, including service, UI projection, boundary, and attestation tests.
  • Signed local macOS package E2E passed: 0.2.0 -> 0.2.1 through a loopback update feed, Squirrel.Mac replacement, and automatic relaunch.

The loopback E2E deliberately bypasses remote Sigstore provenance; the attestation verifier has separate tests. No release has been published.

@github-actions github-actions Bot added the effort/M Under 500 readable lines label Sep 23, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/M Under 500 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant