Skip to content

fix(models): add GPT-6 Sol and Luna metadata - #5633

Merged
Astro-Han merged 2 commits into
apache:mainfrom
Sun-GLiang:codex/fix-gpt6-sol-luna-metadata
Sep 23, 2026
Merged

Astro-Han merged 2 commits into
apache:mainfrom
Sun-GLiang:codex/fix-gpt6-sol-luna-metadata

Conversation

@Sun-GLiang

@Sun-GLiang Sun-GLiang commented Sep 23, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Display gpt-6-sol and gpt-6-luna as GPT-6 Sol and GPT-6 Luna while retaining their request IDs.
  • Offer low, medium, high, xhigh, and max thinking levels on both OpenAI API and Codex OAuth connections. The pinned OpenAI Responses SDK drops GPT-6 none, so the UI no longer offers a nonfunctional Off choice.
  • Route GPT-6 OpenAI API models through Responses so selected reasoning effort reaches the request.
  • The Codex model inventory also advertises ultra for Sol. The current SDK drops that effort, so it is not offered until the request path can send and handle it.

Fixes #5632

Verification

  • Core build and affected catalog/metadata/thinking suites: 61 passed.
  • Runtime build; thinking and Responses wire suites: 66 passed. The wire test checks every offered level for both models on both connection paths against the actual request body.
  • npm run lint, npm run format:check, npm run typecheck, and npm run check:model-metadata: passed.

UI screenshots

Captured with production UI components in temporary Storybook fixtures. The images are GitHub attachments and are not part of the commit. They show selection controls; no live model request was made.

Main task page

Before: raw model IDs After: display names
Main task picker before: raw GPT-6 model IDs Main task picker after: GPT-6 Sol and GPT-6 Luna

Thinking selector after the fix, with Default and the five supported levels:

Main task GPT-6 Sol thinking selector

Model settings

Model catalog Default thinking levels
GPT-6 Sol and GPT-6 Luna in the model settings list GPT-6 Sol default thinking levels without Off

AI use

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: Codex (GPT-6) authored the metadata adaptation and regression tests. The commit includes a Generated-by trailer.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@github-actions github-actions Bot added the effort/S Under 100 readable lines label Sep 23, 2026
@Sun-GLiang
Sun-GLiang force-pushed the codex/fix-gpt6-sol-luna-metadata branch 2 times, most recently from cec07ec to 02bdf7e Compare September 23, 2026 13:55
@Sun-GLiang
Sun-GLiang force-pushed the codex/fix-gpt6-sol-luna-metadata branch from da54df5 to da27e0c Compare September 23, 2026 14:34

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Astro-Han
Astro-Han merged commit 53b01a4 into apache:main Sep 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/S Under 100 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(models): format GPT-6 Sol/Luna names and enable thinking controls

2 participants