Skip to content

fix(release): restore the macOS icon at 16px and 32px #5529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sunrioa wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(release): restore the macOS icon at 16px and 32px #5529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions LICENSE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,11 +469,11 @@ THE SOFTWARE.

electron-builder dependency patches

Source: https://www.npmjs.com/package/app-builder-lib/v/26.15.3
Source: https://www.npmjs.com/package/app-builder-lib/v/26.16.1
https://www.npmjs.com/package/electron-updater/v/6.8.9
Repository: https://github.com/electron-userland/electron-builder
Versions: app-builder-lib 26.15.3; electron-updater 6.8.9
Dependency patch: patches/app-builder-lib+26.15.3.patch
Versions: app-builder-lib 26.16.1; electron-updater 6.8.9
Dependency patch: patches/app-builder-lib+26.16.1.patch
patches/electron-updater+6.8.9.patch
License: MIT

Expand Down
2 changes: 1 addition & 1 deletion apps/desktop/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
"@xterm/addon-fit": "^0.11.0",
"@xterm/xterm": "^6.0.0",
"electron": "43.4.1",
"electron-builder": "26.15.3",
"electron-builder": "26.16.1",

@Astro-Han Astro-Han Sep 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 — In 26.16.1 the macOS auto-update ZIP is built with 7za (-snl) instead of the system zip -y: archive.js:159-174 now sets use7z = true except for NFD paths, and ArchiveTarget preserves symlinks via shouldPreserveSymlinks. In 26.15.3 (archive.js:120) macOS ZIPs went through system zip, so Maka's patch (7za flags) did not touch them; now it does. If 7za handles the Versions/Current symlinks, executable bits or timestamps in Electron Framework differently, Squirrel.Mac / MacUpdater will fail codesign --verify --deep --strict after extraction and auto-update breaks. The only check that would catch this, verify:macos-autoupdate (release.yml:220), runs only in the real release pipeline, and the PR notes verify:macos is unrun. Please run macOS packaging with both verifiers on the signing runner before merging. (The first delta update from a zip-built to a 7za-built archive will also mostly miss the blockmap and download close to the full size; that affects bandwidth only.)

"esbuild": "^0.28.1",
"linkedom": "^0.18.13",
"react": "^19.3.0",
Expand Down
135 changes: 69 additions & 66 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion patches/app-builder-lib+26.15.3.patch → patches/app-builder-lib+26.16.1.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
diff --git a/node_modules/app-builder-lib/out/targets/archive.js b/node_modules/app-builder-lib/out/targets/archive.js
index 9595b4f..fd8fe92 100644
--- a/node_modules/app-builder-lib/out/targets/archive.js
+++ b/node_modules/app-builder-lib/out/targets/archive.js
@@ -101,6 +101,7 @@ function compute7zCompressArgs(format, options = {}) {
@@ -144,6 +144,7 @@ function compute7zCompressArgs(format, options = {}) {
// For all other formats the codec is implicit from the output file extension.
args.push(`-mm=${storeOnly ? "Copy" : "Deflate"}`);
args.push("-mcu");
Expand Down
Loading
Loading