Conversation
The pair claimed synced from heading lockstep while four Current/deferred claims were missing in Chinese. Restore those claims and sibling counterpart links so translation_status matches semantic parity. Fixes apache#5338 Refs apache#4726 Generated-by: Cursor Grok 4.6 Co-authored-by: Cursor <cursoragent@cursor.com>
Astro-Han
left a comment
There was a problem hiding this comment.
Docs-only reconciliation, +10/−8 across the two RFC files. I re-derived parity independently from gh pr diff rather than relying on the PR's own verification list. The pair is genuinely reconciled; I found no blocking issues.
Verified: the four restored claims (A–D from #5338) land at matching strength
| Claim | EN source | ZH at head | Assessment |
|---|---|---|---|
| A — lifecycle evidence is release evidence, not an assumption | windows-sandbox-rfc-v1.md:372-374 |
…zh-CN.md:225 |
Strength preserved verbatim in effect; the preceding fail-closed sentence is retained, not overwritten. |
B — packaged Windows 11 x64 backend + remaining guarantees tracked by Phase 4 #2142 |
windows-sandbox-rfc-v1.md:256,264-266 |
…zh-CN.md:180 |
Both fragments were genuinely absent before (ZH never mentioned Windows 11); #2142 now appears in the §6.5 ledger, not just the header. |
| C — OS version checks alone are insufficient | windows-sandbox-rfc-v1.md:218 |
…zh-CN.md:169 |
Negation kept (不够), and inserted at the same sentence position — before the implemented parenthetical, matching EN. The existing 而非仅凭二进制存在 (≠ "file presence alone") is correctly treated as a distinct claim. |
| D — digest Current / Authenticode deferred split in the §6.5 ledger | windows-sandbox-rfc-v1.md:337-339 |
…zh-CN.md:208 |
The old bullet (随 Phase 3 签名一并落地) really did under-claim — it implied the whole check was deferred, dropping the "digest already enforced in-broker" half. Rewording to readiness 时的 … 校验 plus the digest/Authenticode split fixes a real ledger inaccuracy, not a translation nicety. |
Verified: structure, links, and metadata
- Heading parity — 23 H2/H3 in each file, identical numbered outline (§1–§12 +
W0–W3). The §6.5 snapshot date2026-08-24is unchanged in both headings, as intended. - Anchors resolve — the §-reference set is identical across the pair (
§5,§6.1–§6.5,§7.1,§9) and every one targets a real heading in both files. - Link sets identical — 11 links each, byte-for-byte the same set. The sibling prose links (
./windows-sandbox-rfc-v1.zh-CN.md/./windows-sandbox-rfc-v1.md) resolve to files that exist. counterpart:metadata — added at line 6 of both files in./sibling.mdform, matching bothskills/maka-architecture-docs/references/bilingual-standard.md:84(suggested YAML) and the 7 pre-existing pairs indocs/architecture/. Correctly bidirectional; this closes parity check 8.- Dates aligned, headers untouched —
last_verified: 2026-09-15and bodyUpdatedset in both files; ASF license blocks unmodified (consistent with the pre-commitasf-license-headers.mjs check-stagedhook you cited). - No gate skipped — there is no docs frontmatter/translation-sync checker in
package.json;check:architecturereally is only the desktop renderer ratchet, so not running it is correct.
Verified: sections the PR does not touch were already at parity
I spot-checked §6.3, §9/W1, and §10 to test the claim that A–D were the complete claim-level deviations. They hold up: §6.3 carries the same ten-way-concurrency / desktop-heap quantitative limit in both; §9 W1 has 6/6 checked boxes in each; §10 has 9 bullets plus the same 7-row evidence table; the deferred/暂缓 keyword count is 17 in both. §6.5's enforced (14) and deferred (11) bullet counts also match. I did not find another claim-level gap.
Referenced issues resolve with states consistent with the prose (#2961/#3722/#3174 merged, #2142 and #3952 open), and #3952's Glob/nested-junction work is correctly left out. The "packaged Windows 11 x64" claim is backed by real packaging (scripts/package-windows-x64.mjs, Maka-<ver>-win-x64.exe), and the Authenticode deferral matches the EN source.
Nits
- PR checklist: "Tests cover the change and fail without it" is ticked, but the diff is two markdown files with no test changes. For a docs-only reconciliation that box reads as inaccurate — worth unticking or annotating with "N/A, docs-only".
- EN
- Updated:bump (windows-sandbox-rfc-v1.md:37): the English prose did not change in this diff — only frontmatter. Bumping it to2026-09-15implies an English content edit that didn't happen.last_verifiedmoving is clearly right; consider leaving EN'sUpdatedat2026-08-18, or noting that it tracks frontmatter-only changes. - ZH §6.5 intro reads redundantly (
…zh-CN.md:180): the paragraph now has two adjacent其余…clauses —…其余未标注条目由 #2961 当前强制。其余保证已设计但明确作为后续门禁暂缓…. This is faithful to EN's two sentences, but the Chinese could use e.g.其余保证→尚未强制的保证to avoid the echo. - #5338 accounting (not this PR): the issue says 6 pairs in
docs/architecture/already setcounterpart; there are 7 (the extra one beingllm-compaction-events-log-projection-draft). Immaterial to the change.
English prose did not change, so keep Updated at 2026-08-18; Chinese §6.5 now says 尚未强制的保证 instead of echoing 其余保证. Generated-by: Cursor Grok 4.6 Co-authored-by: Cursor <cursoragent@cursor.com>
|
Thanks for the independent re-derivation. Adopted nits 1–3 in e5ded10:
Left #5338's 6-vs-7 |
Summary
The Windows sandbox RFC pair claimed
translation_status: syncedfrom heading lockstep while four Current/deferred claims were missing in Chinese. This PR restores those claims (A–D) and siblingcounterpartlinks so the published status matches semantic parity.Fixes #5338
Refs #4726
Serialization: #3952 is open and edits both RFC files for Glob/junction policy. This slice does not take that policy; it patches current
main.Verification
rg '^#{2,3} '→ 23 headings on both files; §6.5 heading date2026-08-24unchanged仅凭 OS version check 不够)counterpartpresent both ways in sibling./formnpm run check:asf-headers(also ran as the pre-commit hook)check:architecture(desktop renderer ratchet, not this gate)AI use
Select exactly one:
Tool(s) and scope: Cursor Grok 4.6 drafted the Chinese claim restorations A–D and counterpart metadata from the locked planning paste. The commit retains a
Generated-by: Cursor Grok 4.6trailer.Checklist
Does this PR entail a change in behavior?
Made with Cursor