Repository navigation
fix(bitbucket): use documented Jira issue key field - #1727
Conversation
|
This removes the speculative I also updated the regression test to verify that:
All focused Jira-handoff tests, the full Bitbucket test suite, lint, formatting, mypy, and Refs #606 |
potiuk
left a comment
There was a problem hiding this comment.
Removes the issueKey fallback from pull_request_jira_issues, so only the key field that Data Center's Jira-integration endpoint documents (alongside url) is read. This answers the open question from #1687.
The new {"issueKey": "MAGPIE-999"} fixture fails against the pre-change normalize.py (MAGPIE-999 leaks into jira_issue_keys), so the test really guards the change, not just the happy path.
Trimming, uppercasing and dedup are unchanged, and the full Bitbucket suite passes on the head.
Thanks!
This review was drafted by an AI-assisted tool and
confirmed by an Apache Magpie maintainer. The maintainer
approving this PR has read the findings and signed off. If
something feels off, please reply on the PR and a maintainer
will follow up.More on how Apache Magpie handles maintainer review:
Contributing guide.
Summary
issueKeyfallback from Bitbucket Data Center Jira issue normalization.keyfield from the Jira integration response.issueKey-only object is ignored.Type of change
.claude/skills/<name>/)tools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators`)Test plan
uv run --group dev ruff check src tests --fixuv run --group dev ruff format src testsuv run --group dev mypy src teststools/bitbucket/tests/test_bitbucket.pysuite passesgit diff --checkpassesprek run --all-filespassesContext
Follow-up to #1687.
During review of #1687, it was noted that Bitbucket Data Center's documented Jira integration response exposes Jira issue identifiers through
key, while the normalizer also accepted an undocumentedissueKeyfallback.We did not observe
issueKeyfrom a real Data Center response, so this follow-up removes that speculative fallback and keeps the normalization aligned with the documented response shape.Refs #606