Repository navigation
fix(release-management): accept calendar-date release versions - #1605
Merged
Merged
Conversation
The release-* skills accepted only a dotted numeric version, so a release wave named by date (Airflow's providers waves, e.g. 2026-10-06) could not be checked: release-config preflight blocked "2026-10-06-rc1" as a malformed RC identifier before looking at anything else. A source version may now also be a calendar date YYYY-MM-DD; an impossible date such as 2026-02-30 still blocks. The skills' input tables, the release-build template and the release-config README describe the date form. Generated-by: Claude Opus 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release-* skills accepted only a dotted numeric version (
2.11.0),so a release wave named by date could not be checked at all:
release-config preflightblocked2026-10-06-rc1as a malformed RCidentifier before looking at anything else. Airflow names its providers
waves this way (
providers/2026-10-06), sovote-tally,rc-cutandthe other release skills could not run on them.
A source version may now also be a calendar date
YYYY-MM-DD; animpossible date such as
2026-02-30still blocks. The pattern change isin
tools/release-config(versions.py, with a real-date check inpreflight.py), and the skills' input tables, therelease-build.mdtemplate and the
release-configREADME describe the date form.Type of change
Test plan
2026-10-06accepted; month 13, Feb 30,two-digit years and
rc0rejectedrc-cut 2026-10-06 rc1andvote-tally 2026-10-06-rc1pass, an impossible date blocks; they failwithout the change
prek run --all-filespassesGenerated-by: Claude Opus 5
🤖 Generated with Claude Code
https://claude.ai/code/session_017YohVU217vaHmYDu4zHvuc