bugfix: replace flatten-maven-plugin with easyj-maven-plugin to fix the conflict between shade and flatten#4626
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4626 +/- ##
=============================================
+ Coverage 48.90% 49.04% +0.13%
- Complexity 4042 4056 +14
=============================================
Files 734 734
Lines 25577 25577
Branches 3156 3156
=============================================
+ Hits 12509 12544 +35
+ Misses 11732 11698 -34
+ Partials 1336 1335 -1
|
funky-eyes
approved these changes
May 22, 2022
funky-eyes
left a comment
funky-eyes
left a comment
Contributor
There was a problem hiding this comment.
LGTM 要不要顺便把版本号改为1.5.2-SNAPSHOT ?
Contributor
Author
done |
wangliang181230
changed the title
Contributor
Author
|
等下，插件有个优化，我刚提交，等上传OSS后，我升下版本。 |
1 task
wangliang181230
changed the title
shade and flatten, replace flatten-maven-plugin with easyj-maven-plugin
wangliang181230
changed the title
shade and flatten, replace flatten-maven-plugin with easyj-maven-pluginflatten-maven-plugin with easyj-maven-plugin to fix the conflict between shade and flatten
Contributor
Author
|
|
liuqiufeng
pushed a commit
to liuqiufeng/seata
that referenced
this pull request
Jun 11, 2022
…ix the conflict between `shade` and `flatten` (apache#4626)
YvCeung
pushed a commit
to YvCeung/incubator-seata
that referenced
this pull request
Dec 25, 2025
…ix the conflict between `shade` and `flatten` (apache#4626)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bugfix: replace
flatten-maven-pluginwitheasyj-maven-pluginto fix the conflict betweenshadeandflatten问题修复：使用
easyj-maven-plugin插件代替flatten-maven-plugin插件，以修复shade插件与flatten插件不兼容的问题，导致seata-all.pom中的${revision}并没有被替换为具体的版本号，导致应用端引用后打包失败。另外，
easyj-maven-plugin插件还可以简化所有pom文件。fixes #4618
easyj-maven-plugin插件源码：https://github.com/easyj-projects/easyj-maven-plugin/tree/develop