Skip to content

Bump flatten-maven-plugin to 1.3.0#1187

Merged
tiagobento merged 1 commit into
apache:mainfrom
tiagobento:update-flatten-maven-plugin-to-1.3.0
Aug 17, 2022
Merged

Bump flatten-maven-plugin to 1.3.0#1187
tiagobento merged 1 commit into
apache:mainfrom
tiagobento:update-flatten-maven-plugin-to-1.3.0

Conversation

@tiagobento

Copy link
Copy Markdown
Contributor

This fixes an issue first reported by @hasys, where he could not run mvn gwt:run on packages/serverless-workflow-diagram-editor/sw-editor/sw-editor-kogito-app.

We found out this issue was a bug (mojohaus/flatten-maven-plugin#100) on flatten-maven-plugin, which was clashing with shade-maven-plugin, leaving the installed POM with a reference to the CI friendly version ${revision}.

We contacted the maintainers of flatten-maven-plugin through this issue mojohaus/flatten-maven-plugin#292 and they kindly released a new version containing the fix (mojohaus/flatten-maven-plugin#281) right away. (Thanks a lot, @slawekjaranowski 🎉)

@tiagobento tiagobento requested a review from hasys August 17, 2022 12:15
@ederign

ederign commented Aug 17, 2022

Copy link
Copy Markdown
Member

Thanks a lot @slawekjaranowski

@hasys

hasys commented Aug 17, 2022

Copy link
Copy Markdown
Contributor

Works as a charm, thank you @slawekjaranowski and @tiagobento!

@tiagobento tiagobento merged commit ae62f68 into apache:main Aug 17, 2022
ricardozanini pushed a commit to ricardozanini/kogito-tooling that referenced this pull request Sep 23, 2024
Co-authored-by: Jenkins CI <noreply@redhat.com>
domhanak pushed a commit to domhanak/kie-tools that referenced this pull request Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants