feat: add realtimeSegmentsMode query context param#19486
Open
jtuglu1 wants to merge 2 commits into
Open
Conversation
jtuglu1
force-pushed
the
realtime-segments-mode-query-context
branch
from
9d19281 to
4dcf459
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Member
FrankChen021
left a comment
FrankChen021
left a comment
There was a problem hiding this comment.
I have reviewed the code for correctness, edge cases, concurrency, and integration risks; no issues found.
Reviewed 6 of 6 changed files.
This is an automated review by Codex GPT-5.5
Contributor
abhishekrb19
left a comment
abhishekrb19
left a comment
There was a problem hiding this comment.
This makes sense. Left a few comments. It’d be good for @aho135 to take a look at this as well.
Contributor
|
Thanks for the update @jtuglu1 This makes sense to me Shall we go ahead and update the auto-completion as well? |
aho135
reviewed
May 20, 2026
jtuglu1
force-pushed
the
realtime-segments-mode-query-context
branch
from
5ab2659 to
e0d276d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A prior commit added the
realtimeSegmentsOnlyquery context flag, which wasn't exhaustive in the 3 possible options users might want (include realtime segments, exclude realtime segments, exclusively query realtime segments). This adds the query context parameterrealtimeSegmentsModeand deprecatesrealtimeSegmentsOnly.realtimeSegmentsOnly=truemaps torealtimeSegmentsOnly=exclusiveandrealtimeSegmentsOnly=falsemaps torealtimeSegmentsOnly=include.In addition to just being able to query realtime segments, this is useful when performing things like blue/green deployments and you only want to query new historical replica ASGs and not touch any "live" nodes (neither realtime nor historical).
Release note
This adds the query context parameter
realtimeSegmentsModeand deprecatesrealtimeSegmentsOnly. realtimeSegmentsOnly=true maps to realtimeSegmentsOnly=exclusive and realtimeSegmentsOnly=false maps to realtimeSegmentsOnly=include.This is useful when performing things like blue/green deployments and you only want to query new historical replica ASGs and not touch any "live" nodes (neither realtime nor historical).
This PR has: