[fix](function) fix map_contains_entry runtime error when TIMESTAMPTZ is map key or value#63124
Open
Mryange wants to merge 1 commit intoapache:masterfrom
Open
[fix](function) fix map_contains_entry runtime error when TIMESTAMPTZ is map key or value#63124Mryange wants to merge 1 commit intoapache:masterfrom
Mryange wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
/review |
Contributor
There was a problem hiding this comment.
No blocking issues found in this review.
Critical checkpoint conclusions:
- Goal and proof: The PR fixes
map_contains_entryrejectingTIMESTAMPTZby aligning the guard withdispatch_switch_all; the added regression covers TIMESTAMPTZ as both map key and value, literals and table columns, hits/misses, and null search arguments. - Scope: The code change is small and focused on the BE support check plus targeted regression coverage.
- Concurrency/lifecycle/config/storage compatibility: Not applicable; this is a scalar-function execution guard and regression test only.
- Parallel code paths: The FE/Nereids signature already coerces map key/value search arguments to comparable types; BE dispatch already supports
TYPE_TIMESTAMPTZ, so the guard now matches the downstream path. - Test coverage: Regression test output is deterministic for table queries via
ORDER BY; scalar single-row queries do not need ordering. No additional user-provided focus points were supplied. - Performance/observability: No material performance or observability impact identified; the guard uses the same dispatch mechanism as execution.
I did not run the regression test in this review environment.
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 29355 ms |
Contributor
TPC-DS: Total hot run time: 170532 ms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: N/A
Problem Summary:
map_contains_entrythrows aRUNTIME_ERRORat BE execution time when the MAP column hasTIMESTAMPTZas its key or value type. Root cause:FunctionMapContainsEntry::is_equality_comparison_supportedhard-coded a list of accepted primitive types (is_date_type,is_time_type,is_number,is_string_type,is_ip) but omittedTYPE_TIMESTAMPTZ. As a result, the pre-execution type guard always rejected TIMESTAMPTZ even though the underlyingdispatch_switch_all+ColumnVector::compare_atpath supports it correctly. The fix replaces the hand-maintained list with a direct call todispatch_switch_all, which already covers TIMESTAMPTZ in itsDATETIMEbranch, making the guard consistent with the actual dispatch layer.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)