feat(webhook): allow closing incidents via request body instead of url#8939
Merged
Conversation
Contributor
|
Looks good. |
Contributor
Author
|
Hey @klesh These endpoints are basically just thin wrappers — they grab issueKey from the body and call the existing closeIssue() function, that's it. Nothing new that needs testing beyond what's already covered. Would you be okay merging this and I'll add tests in a follow-up? |
klesh
approved these changes
Jun 22, 2026
klesh
left a comment
klesh
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Thanks for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8910
Summary
Added new webhook close issue endpoints that accept
issueKeyin the request body instead of the URL path. This enables Kibana v8.x webhook connectors to close incidents using a fixed URL.Changes
POST /connections/:connectionId/issue/closePOST /connections/by-name/:connectionName/issue/closeissueKeycloseIssue()logic to avoid code duplicationNotes