fix factorial(21) should not overflow when PostgreSQL returns a numeric answer#22306
Open
xiedeyantu wants to merge 1 commit into
Open
fix factorial(21) should not overflow when PostgreSQL returns a numeric answer#22306xiedeyantu wants to merge 1 commit into
xiedeyantu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
factorial(21)should not overflow when PostgreSQL returns a numeric answer #22259.Rationale for this change
factorialwas previously implemented using anInt64lookup table, which causedfactorial(21)to fail with an overflow error. This differs from PostgreSQL, which returns an exact numeric result for this input.This change improves PostgreSQL compatibility by allowing
factorialto return exact results beyond thei64boundary, while still preserving overflow behavior once the supported decimal range is exceeded.What changes are included in this PR?
factorialto returnDecimal256(76, 0)instead ofInt64.20!.i256multiplication.Decimal256range.Are these changes tested?
Yes.
This PR updates sqllogictest coverage for
factorial, including:factorial(21)Validated with:
cargo test -p datafusion-sqllogictest --test sqllogictests scalarAre there any user-facing changes?
Yes.
factorial(21)now returns51090942171709440000instead of raising an overflow error, and the return type offactorialis nowDecimal256(76, 0)rather thanInt64.