feat: Restore nullability when consuming substrait fields#22105
Open
neilconway wants to merge 2 commits into
Open
feat: Restore nullability when consuming substrait fields#22105neilconway wants to merge 2 commits into
neilconway wants to merge 2 commits into
Conversation
Contributor
Author
|
Initially motivated by the test failure in #22089, but seems worth improving as a separate task rather than just weakening the test assertions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The Substrait logical-plan consumer was discarding field nullability when reconstructing DataFusion schemas from Substrait struct types. Nullability matters because a Substrait plan may have been produced or optimized using non-null guarantees.
This also improves DataFusion <-> Substrait round-trip fidelity: required fields encoded by the producer are preserved when the plan is consumed again, instead of being widened to nullable.
What changes are included in this PR?
NamedStructschemas into DataFusion schemas.Requiredas non-nullable, andNullable,Unspecified, or unknown nullability values as nullable.UserDefinedTypeReferencenon-nullable because it does not carry nullability metadata.ReadRelschema compatibility when the Substrait schema requires a field to be non-null but the resolved DataFusion table schema marks it nullable.Structfields.ListandMapchild nullability compatibility as future work, since their child nullability is not faithfully reconstructed today.Are these changes tested?
Yes; new tests added.
Are there any user-facing changes?
We are a bit stricter when consuming Substrait plans now, but that could prevent problems: for example, if a Substrait plan was produced under the assumption that a field
xis non-nullable but the local DataFusion schema allows null values inx, executing the plan might produce unexpected results.