Consolidate and document SQL AST shims#22094
Open
alamb wants to merge 6 commits into
Open
Conversation
andygrove
approved these changes
May 10, 2026
alamb
commented
May 11, 2026
| } | ||
| } | ||
|
|
||
| #[derive(Clone, PartialEq, Eq, PartialOrd, Hash, Debug)] |
Contributor
Author
There was a problem hiding this comment.
this stuff is all moved to sql.rs and I put a module level comment on it
timsaucer
approved these changes
May 11, 2026
Member
timsaucer
left a comment
timsaucer
left a comment
There was a problem hiding this comment.
This is a nice cleanup, and something I wasn't 100% happy with when I did it. Thank you!
alamb
commented
May 11, 2026
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| //! Local copies of [`sqlparser::ast`] structures |
Contributor
Author
There was a problem hiding this comment.
this is the documentation that explains what is going on
Contributor
Author
|
Since I think this will conflict with @andygrove 's upgrade of sqlparser and I don't think it will be potentially controversial, I am mergeing now |
…fusion into alamb/comments_about_sql_copy
github-actions
Bot
removed
the
documentation
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
Merge was failing due to |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
While upgrading sqlparser, it was not clear why there were feature gates for the
sqlfeature: https://github.com/apache/datafusion/pull/22069/changes#r3204705488There is a mode to avoid the
sqlparserdependency, added by @timsaucer insqlfeature to make sql planning optional #17332I think this feature makes sense but it is a little hard to understand because it is implemented with a bunch of
#[cfg(not(feature = "sql"))]and there is no central place that explains the design.What changes are included in this PR?
Are these changes tested?
Yes by CI
Are there any user-facing changes?