Skip to content

Fixes #8886. Add integration test coverage for CyberArk Vault alternative authentication methods#8896

Merged
jamesnetherton merged 1 commit into
apache:mainfrom
JiriOndrusek:fix/8886
Jul 22, 2026
Merged

Fixes #8886. Add integration test coverage for CyberArk Vault alternative authentication methods#8896
jamesnetherton merged 1 commit into
apache:mainfrom
JiriOndrusek:fix/8886

Conversation

@JiriOndrusek

@JiriOndrusek JiriOndrusek commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

requires #8894 to be merged

Summary

  • Add integration tests for three CyberArk Vault authentication methods: username/password, pre-authenticated token, and custom ConjurClient via CDI registry
  • Add ConjurClientProducer CDI bean with proper @Disposes lifecycle management
  • Rename config properties from read/write to reader/writer for clarity
  • Change container log consumers to debug level to reduce noise
  • Update README.adoc with optional env vars for alternative auth methods

Dependencies

Depends on #8894 (fix/8884) — this PR is stacked on top of it.

Test plan

  • testGetSecretByPassword — creates secret, retrieves via password auth
  • testGetSecretByToken — creates secret, retrieves via pre-authenticated token
  • testGetSecretByClient — creates secret, retrieves via CDI-injected ConjurClient
  • testUnauthorizedFailure — verifies 403 for unauthorized create (renamed for log clarity)

🤖 Generated with Claude Code

@jamesnetherton jamesnetherton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the withLogConsumer changes were intended? If so, probably better to keep the original log level. Makes it easier to debug for CI failures etc.

@jamesnetherton

Copy link
Copy Markdown
Contributor

@JiriOndrusek please rebase & address review feedback.

@JiriOndrusek

Copy link
Copy Markdown
Contributor Author

@JiriOndrusek please rebase & address review feedback.

will do, thanks!

…lternative authentication methods

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jamesnetherton
jamesnetherton merged commit 69760a3 into apache:main Jul 22, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants