Skip to content

[3.33] fix: use x509 certificates for ftp extensions sftp tests#8892

Merged
jamesnetherton merged 1 commit into
apache:3.33.xfrom
gansheer:fix/8887-platform-failure
Jul 20, 2026
Merged

[3.33] fix: use x509 certificates for ftp extensions sftp tests#8892
jamesnetherton merged 1 commit into
apache:3.33.xfrom
gansheer:fix/8887-platform-failure

Conversation

@gansheer

@gansheer gansheer commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Closes #8887

The fix from main can't be backported due to net.i2p.crypto:eddsa still being present, so I rollbacked to x509 certificates that worked before.

@gansheer

Copy link
Copy Markdown
Contributor Author

Ran it locally against quarkus-platform 3.33, the FTP tests pass.

@gansheer
gansheer marked this pull request as ready for review July 16, 2026 22:05
@gansheer
gansheer force-pushed the fix/8887-platform-failure branch from 73a4064 to 594789a Compare July 17, 2026 07:15

@JiriOndrusek JiriOndrusek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though the test coverage is slightly smaller (or different) - switch from SSH to privateKey - for the maintenance branch this approach should be good enough.

@JiriOndrusek JiriOndrusek changed the title fix: use x509 certificates for ftp extensions sftp tests [3.33] fix: use x509 certificates for ftp extensions sftp tests Jul 17, 2026
@JiriOndrusek

Copy link
Copy Markdown
Contributor

@gansheer I took the liberty of adding the [3.33] prefix to the PR title - hope that's okay!

@gansheer

gansheer commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

Even though the test coverage is slightly smaller (or different) - switch from SSH to privateKey - for the maintenance branch this approach should be good enough.

TBH I can't do more whitout adding some ugly (and dumb) code to avoid the issue. Next LTS is more stable and has the tests and the feature.

@gansheer I took the liberty of adding the [3.33] prefix to the PR title - hope that's okay!

Sure, should it be the prefered way for a PR targeting non-main version ?

@jamesnetherton

Copy link
Copy Markdown
Contributor

should it be the prefered way for a PR targeting non-main version

Yes, makes it easier to backport PRs.

@jamesnetherton
jamesnetherton merged commit e0fa3ae into apache:3.33.x Jul 20, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants