AVRO-4253: [Java] fix memory leak#3774
Open
mkeskells wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Primary - to fix the memory leak described in AVRO-4253, a memory leak in FastReaderBuilder
Also improves the implementation and documentation of WeakIdentityHashMap.
Unfortunately the main fix depends on this, so needed do it as an enabler. We could do this a s seperate PR and layer the memory leak on top, but the complexity of the PR isnt that high, so though it was better to address both concens in a sinple PR
Verifying this change
(Please pick one of the following options)
This change added unit test
Documentation
No new feature added