AVRO-4176: Java parser allows field type to be object with custom type#3772
Open
opwvhk wants to merge 2 commits into
Open
AVRO-4176: Java parser allows field type to be object with custom type#3772opwvhk wants to merge 2 commits into
opwvhk wants to merge 2 commits into
Conversation
The test cases for self reference unions contained a bug that seemed to make the parsing bug necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR fixes AVRO-4176: Java parser allows field type to be object with custom type.
Verifying this change
The description of the bug points to the change in
Schema.java, and a test was added toTestSchemato prove the fix.The change in
TestUnionSelfReferencewas needed because it contained the same bug as mentioned in the Jira issue: it used{"type": "Node"}as a type reference.Documentation
yes/ no)docs / JavaDocs / not documented)