refactor: simplify waker notification paths - #341
Merged
Merged
Conversation
tisonkun
changed the title
tisonkun
marked this pull request as draft
October 1, 2026 17:01
tisonkun
marked this pull request as ready for review
October 2, 2026 10:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Executor waker operations, including cloning, waking, and dropping, are expected not to panic. Remove batch-wake unwind recovery and the corresponding per-API promises and tests, and record the contract change under Notable changes.
Use an explicit semaphore release loop that reuses the stack buffer and wakes each batch after unlocking. Simplify MPSC, MPMC, and SPMC disconnect notifications and waker re-registration while preserving cancellation handoff, unlocked callbacks and destruction, and user-value panic cleanup.
Validation:
cargo x test(615 passed),cargo x lint, andcargo x check(feature matrix).Refs #335.
Follow-up research: #342.