Skip to content

GH-49973: [C++] Fix Gandiva string length checks#49984

Open
puneetdixit200 wants to merge 1 commit into
apache:mainfrom
puneetdixit200:gh-49973-gandiva-string-lengths
Open

GH-49973: [C++] Fix Gandiva string length checks#49984
puneetdixit200 wants to merge 1 commit into
apache:mainfrom
puneetdixit200:gh-49973-gandiva-string-lengths

Conversation

@puneetdixit200
Copy link
Copy Markdown

@puneetdixit200 puneetdixit200 commented May 18, 2026

Rationale

Fixes remaining Gandiva string length safety issues from GH-49973.

What changed

  • Uses checked multiplication before addition in quote_utf8 and to_hex_binary.
  • Rejects negative valid input lengths in concat_ws before allocation/copy.
  • Adds targeted regression tests for overflow and negative length handling.

Verification

  • git diff --check
  • ctest --test-dir cpp\build-gandiva-vs-conda-zlib -C Release -R gandiva-precompiled-test --output-on-failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant