GH-49981: [R][Packaging] Support building R package under r-universe/r-wasm#49982
GH-49981: [R][Packaging] Support building R package under r-universe/r-wasm#49982amoeba wants to merge 5 commits into
Conversation
|
@github-actions crossbow submit test-r-r-universe-wasm |
|
Revision: 18fe759 Submitted crossbow builds: ursacomputing/crossbow @ actions-8ee2d3b170
|
|
@github-actions crossbow submit test-r-r-universe-wasm |
|
Revision: a2fa12a Submitted crossbow builds: ursacomputing/crossbow @ actions-4178688350
|
|
@github-actions crossbow submit test-r-r-universe-wasm |
|
Revision: 5ee8457 Submitted crossbow builds: ursacomputing/crossbow @ actions-3963128ccf
|
amoeba
changed the title
|
@github-actions crossbow submit test-r-r-universe-wasm |
|
Revision: 5ee8457 Submitted crossbow builds: ursacomputing/crossbow @ actions-8c87567db5
|
amoeba
requested review from
assignUser,
jonkeane,
kou,
raulcd and
thisisnic
as code owners
|
@github-actions crossbow submit test-r-r-universe-wasm |
|
Revision: b37e9d0 Submitted crossbow builds: ursacomputing/crossbow @ actions-0aa60bce30
|
jonkeane
left a comment
jonkeane
left a comment
There was a problem hiding this comment.
Thanks for this! One comment about naming and then mostly questions for my understanding. This is exciting to see working!
| env: | ||
| CMAKE_BUILD_TYPE: MinSizeRel | ||
|
|
||
| test-r-r-universe-wasm: |
There was a problem hiding this comment.
| test-r-r-universe-wasm: | |
| test-r-universe-wasm: |
I know how we got here, but the -r-r- seemed a little silly. We could also call this test-r-wasm yeah? I know we are using r-universe's build machinery to accomplish this, but it's really the only r + wasm test right?
There was a problem hiding this comment.
:) test-r-wasm sounds good.
| -DARROW_DEPENDENCY_USE_SHARED=${ARROW_DEPENDENCY_USE_SHARED:-ON} \ | ||
| -DARROW_ENABLE_THREADING=${ARROW_ENABLE_THREADING:-ON} \ | ||
| -DARROW_FLIGHT=${ARROW_FLIGHT:-OFF} \ |
There was a problem hiding this comment.
Were these defaults we were getting already via the cmake? Or are these actually enabling / disabling things?
OH, I see for ARROW_ENABLE_THREADING that would have defaulted to on, but we need to set it to off for wasm in nixlibs.r and same with ARROW_DEPENDENCY_USE_SHARED. But what about ARROW_FLIGHT ? It doesn't look like that is (over)ridden down below? I'm fine with it being here (I think it would default to off), but that's slightly separate from this PR, yeah? Or am I missing something?
github-actions
Bot
added
awaiting changes
|
@github-actions crossbow submit test-r-wasm |
|
Revision: 7eb72ac Submitted crossbow builds: ursacomputing/crossbow @ actions-df03aafab4
|
2 participants
Rationale for this change
Arrow C++ already supports Emscripten but the R package can't be built by either the r-wasm or r-universe projects in its current state. We just need to make the bundled build Emscripten aware we're in an Emscripten environment for this to work.
What changes are included in this PR?
build_arrow_static.shEmscripten-aware by adding support for being called with a wrapper programAre these changes tested?
Yes. The R package builds in a local docker r-wasm-based container as well as in Crossbow
Are there any user-facing changes?
No.