refactor: unify internal naming of allow_invalid_certificates#718
Conversation
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM
make sense to align with the builder method with_allow_invalid_certificates
btw ci is failing due to formatting issue
|
🎉 |
|
This may have broken CI on main 🥲 https://github.com/apache/arrow-rs-object-store/actions/runs/27298445894 |
|
I re-ran the CI and it passed the second time, so it must just be a flakey test |
|
its green! looks like it might be an intermittent issue |
|
The way in which that failed does not make sense to me as far as I undestand the rules of cargo test. It is as if |
|
🤷♂️ we'll see if it happens again! Let's just say it's GitHub's fault haha |
Which issue does this PR close?
None, because should not be mentioned in a changelog.
Is internal-only
Rationale for this change
Inconsistent between external api and internal api.
What changes are included in this PR?
Rename internal variable
Are there any user-facing changes?
No user facing or breaking changes