Skip to content

refactor: unify internal naming of allow_invalid_certificates#718

Merged
kylebarron merged 2 commits into
apache:mainfrom
CommanderStorm:allow_invalid_certificates
Jun 10, 2026
Merged

refactor: unify internal naming of allow_invalid_certificates#718
kylebarron merged 2 commits into
apache:mainfrom
CommanderStorm:allow_invalid_certificates

Conversation

@CommanderStorm

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

None, because should not be mentioned in a changelog.
Is internal-only

Rationale for this change

Inconsistent between external api and internal api.

What changes are included in this PR?

Rename internal variable

Are there any user-facing changes?

No user facing or breaking changes

@kevinjqliu kevinjqliu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

make sense to align with the builder method with_allow_invalid_certificates

btw ci is failing due to formatting issue

@kevinjqliu kevinjqliu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kylebarron kylebarron merged commit af634d0 into apache:main Jun 10, 2026
9 checks passed
@CommanderStorm CommanderStorm deleted the allow_invalid_certificates branch June 10, 2026 19:01
@CommanderStorm

Copy link
Copy Markdown
Contributor Author

🎉

@kylebarron

kylebarron commented Jun 10, 2026

Copy link
Copy Markdown
Member

This may have broken CI on main 🥲 https://github.com/apache/arrow-rs-object-store/actions/runs/27298445894

@kylebarron

Copy link
Copy Markdown
Member

I re-ran the CI and it passed the second time, so it must just be a flakey test

@kevinjqliu

Copy link
Copy Markdown
Contributor

its green! looks like it might be an intermittent issue

@CommanderStorm

Copy link
Copy Markdown
Contributor Author

The way in which that failed does not make sense to me as far as I undestand the rules of cargo test.

It is as if cargo test narrowed the feature set to what is actually being used in the testcase..
I checked release notes and commit logs and did not find any smoking guns of mayne a new version rolling out or something. strange.

@kylebarron

kylebarron commented Jun 10, 2026

Copy link
Copy Markdown
Member

🤷‍♂️ we'll see if it happens again! Let's just say it's GitHub's fault haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants