Make schema_fields templated in GCSToBigQueryOperator#69108
Open
nikolauspschuetz wants to merge 1 commit into
Open
Make schema_fields templated in GCSToBigQueryOperator#69108nikolauspschuetz wants to merge 1 commit into
nikolauspschuetz wants to merge 1 commit into
Conversation
schema_fields was not a template field, so a templated value (a Variable or XComArg resolving to a schema) passed to GCSToBigQueryOperator was never rendered and reached BigQuery unresolved. Mark it templated, matching how BigQueryUpdateTableSchemaOperator already templates schema_fields_updates.
boring-cyborg
Bot
added
area:providers
provider:google
SameerMesiah97
left a comment
SameerMesiah97
left a comment
Contributor
There was a problem hiding this comment.
Looks fine. Just have one comment.
| dag_id="test_gcs_to_bq_schema_fields_templating", | ||
| schedule=None, | ||
| start_date=datetime(2024, 1, 1), | ||
| render_template_as_native_obj=True, |
Contributor
There was a problem hiding this comment.
I am just wondering if render_template_as_native_obj=True is strictly required for this test? If not, we can skip creating the DAG object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCSToBigQueryOperator.schema_fieldswas not a template field, so a templated value (a Variable orXComArgresolving to a schema) passed to it was never rendered — the raw, unresolved object reached BigQuery (e.g. surfacing as "Object of type MappedArgument is not JSON serializable").This marks
schema_fieldsas templated and registers ajsonrenderer, matching howBigQueryUpdateTableSchemaOperatoralready templatesschema_fields_updates. Callers passing a plain list/dict are unaffected; only the previously-broken templated case changes.closes: #31481
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines