Make test fixtures clean up the bundle and team rows they create#69093
Open
anishgirianish wants to merge 1 commit into
Open
Make test fixtures clean up the bundle and team rows they create#69093anishgirianish wants to merge 1 commit into
anishgirianish wants to merge 1 commit into
Conversation
e16c57a to
154d55c
Compare
154d55c to
fadb51b
Compare
Contributor
Author
|
cc: @ferruzzi |
|
Nice clean implementation. One minor thought: the early return could be moved up to reduce nesting. But overall this looks solid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was generative AI tooling used to co-author this PR?
Make the database test fixtures clean up the bundle and team rows they create, in foreign-key-safe order, so tests stop leaking them. Document the fixtures and isolation pattern.
related: #68374
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.