Skip to content

Make test fixtures clean up the bundle and team rows they create#69093

Open
anishgirianish wants to merge 1 commit into
apache:mainfrom
anishgirianish:fix-test-fixture-cleanup-bundles-teams
Open

Make test fixtures clean up the bundle and team rows they create#69093
anishgirianish wants to merge 1 commit into
apache:mainfrom
anishgirianish:fix-test-fixture-cleanup-bundles-teams

Conversation

@anishgirianish

@anishgirianish anishgirianish commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Make the database test fixtures clean up the bundle and team rows they create, in foreign-key-safe order, so tests stop leaking them. Document the fixtures and isolation pattern.

related: #68374


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@anishgirianish anishgirianish force-pushed the fix-test-fixture-cleanup-bundles-teams branch 5 times, most recently from e16c57a to 154d55c Compare June 28, 2026 04:39
@anishgirianish anishgirianish force-pushed the fix-test-fixture-cleanup-bundles-teams branch from 154d55c to fadb51b Compare June 28, 2026 04:55
@anishgirianish

Copy link
Copy Markdown
Contributor Author

cc: @ferruzzi

@goransh-buh

Copy link
Copy Markdown

Nice clean implementation. One minor thought: the early return could be moved up to reduce nesting. But overall this looks solid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants