Close S3 download_file handle after download or failure#69084
Merged
Conversation
S3Hook.download_file opened a local file (or NamedTemporaryFile with delete=False), streamed the object into it, and returned the path without ever closing the handle, relying on garbage collection to release the descriptor. On a download error the handle leaked the same way. Closing it in a finally releases the descriptor on every path while keeping the downloaded file on disk for the caller.
boring-cyborg
Bot
added
area:providers
provider:amazon
shahar1
approved these changes
Jun 27, 2026
henry3260
approved these changes
Jun 28, 2026
jroachgolf84
approved these changes
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S3Hook.download_fileopened a local file (or aNamedTemporaryFilewithdelete=False), streamed the object into it, and returned the path without ever closing the handle — relying on garbage collection to release the descriptor. On a download error the handle leaked the same way.Closing it in a
finallyreleases the descriptor on every path (success and failure) while keeping the downloaded file on disk for the caller. Adds a regression test asserting the handle is closed when the download raises.related: #69077
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines