Java SDK: Serialize coordinator client send/receive for thread safety#69080
Open
FrankYang0529 wants to merge 1 commit into
Open
Java SDK: Serialize coordinator client send/receive for thread safety#69080FrankYang0529 wants to merge 1 commit into
FrankYang0529 wants to merge 1 commit into
Conversation
A Java task may call the SDK client from multiple threads. Every call goes through one request/response channel to the supervisor. So it must be thread safe. Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl,
potiuk and
uranusjr
as code owners
uranusjr
reviewed
Jun 28, 2026
| var frame: IncomingFrame? = null | ||
| suspend fun communicateImpl(body: Any): Any = | ||
| commMutex.withLock { | ||
| val requestId = nextId.fetchAndAdd(1) |
Member
There was a problem hiding this comment.
I think this should be outside of the lock since nextId handles concurrency itself?
uranusjr
reviewed
Jun 28, 2026
Comment on lines
+123
to
+129
| sendMessage(requestId, body) | ||
| processOnce(::handle) | ||
| val received = frame ?: throw ApiError("No response received") | ||
| if (received.id != requestId) { | ||
| throw ApiError("response id ${received.id} does not match request id $requestId") | ||
| } | ||
| received.body ?: Unit |
Member
There was a problem hiding this comment.
I wonder if there’s a way to do though outside of a lock since we have the request ID to identify which response if for which. IIRC the Python implementation does this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard the whole send/receive pair in
communicateImplwith aMutexso concurrent task threads are serialized over the single channel, and verify the response id echoes the request id to reject a mis-paired response.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.