Triggerer: Add Test Coverage for Triggerer Metrics#68545
Draft
SameerMesiah97 wants to merge 2 commits into
Draft
Triggerer: Add Test Coverage for Triggerer Metrics#68545SameerMesiah97 wants to merge 2 commits into
SameerMesiah97 wants to merge 2 commits into
Conversation
Add unit tests verifying emission of the triggerer_heartbeat, triggers.succeeded, and triggers.failed metrics.
eladkal
added
the
changelog:skip
potiuk
added
the
ready for maintainer review
Contributor
Author
|
Requesting review for this. |
vatsrahul1001
added
backport-to-v3-3-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds dedicated unit tests covering emission of the
triggerer_heartbeat,triggers.succeeded, andtriggers.failedmetrics in the triggerer.Rationale
These metrics are part of the triggerer's observability surface and may be consumed by external monitoring and alerting systems. While the underlying triggerer functionality is already covered by existing tests, metric emission is not currently verified directly.
Adding dedicated metric tests helps guard against regressions such as accidental metric removal or renaming.
Tests
Added unit tests verifying emission of the following metrics:
triggerer_heartbeattriggers.succeededtriggers.failedBackwards Compatibility
This change adds test coverage only and does not modify trigger execution behavior, lifecycle semantics, metrics, or public APIs.