Skip to content

Crawler corrections January 2017#245

Open
ajdavis wants to merge 4 commits into
aosabook:masterfrom
ajdavis:crawler-corrections-jan-2017
Open

Crawler corrections January 2017#245
ajdavis wants to merge 4 commits into
aosabook:masterfrom
ajdavis:crawler-corrections-jan-2017

Conversation

@ajdavis

@ajdavis ajdavis commented Jan 22, 2017

Copy link
Copy Markdown
Contributor

Fix a code-wart that a reader pointed out to me, deal with xkcd.com's change to TLS-only, and acknowledge updates to Python and aiohttp since publication.

CC: @gvanrossum, but your review is not required unless you want to.

The example "Future" class has both a result field and a result function.
Luckily the function was never called so it's ok that the result field overwrote it.
Python 3.4 is no longer latest, aiohttp API has changed.
The example code doesn't implement TLS, but xkcd.com is now TLS-only.
@MichaelDiBernardo

Copy link
Copy Markdown
Collaborator

Thanks for pinging me via email on this. Sometime in the next couple of weeks I will merge and publish a new web version; I should also be able to update the print version with these corrections (and others that have been submitted since release), but that may take awhile longer.

@Malix-Labs

Copy link
Copy Markdown

Thanks for pinging me via email on this. Sometime in the next couple of weeks I will merge and publish a new web version; I should also be able to update the print version with these corrections (and others that have been submitted since release), but that may take awhile longer.

a while, while longer

@mazhongbin

mazhongbin commented Jan 9, 2023 via email

Copy link
Copy Markdown

@stoic94

stoic94 commented Jan 9, 2023 via email

Copy link
Copy Markdown

@jankey110

jankey110 commented Jan 9, 2023 via email

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants