fix: refactor kit airdrop to avoid deprecated transaction confirmer (#1784)#1850
Open
mansiverma897993 wants to merge 1 commit into
Open
fix: refactor kit airdrop to avoid deprecated transaction confirmer (#1784)#1850mansiverma897993 wants to merge 1 commit into
mansiverma897993 wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 3406676 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #1784 by refactoring the internal airdrop confirmation code in @solana/kit to not rely on the deprecated waitForRecentTransactionConfirmationUntilTimeout function.
Instead, signature-only confirmation is achieved by racing getRecentSignatureConfirmationPromise and getTimeoutPromise directly using safeRace from @solana/promises. The dependency @solana/promises has also been explicitly added to @solana/kit workspace dependencies, and the typescript interfaces have been updated to represent the signature-only config configuration explicitly.