fix: include v0 preamble in offchain message size checks#1741
Open
ChargingFoxSec wants to merge 2 commits into
Open
fix: include v0 preamble in offchain message size checks#1741ChargingFoxSec wants to merge 2 commits into
ChargingFoxSec wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 24667a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 47 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The v0 1232-byte message size check only counted the message body. This allowed messages to pass validation when the body was under the limit, even if the full encoded message with the v0 preamble was over 1232 bytes.
Summary of Changes
Fixes #1726.
This updates the v0 offchain message validation to account for the preamble size when checking the 1232-byte formats.
It also adds encode and decode tests for the boundary case where the body alone fits, but the full v0 encoded message does not.