Add useTrackedDataSwr to the @solana/react/swr adapter#1727
Open
mcintyre94 wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: b0480c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 47 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Jun 5, 2026
Member
Author
BundleMonFiles updated (25)
Unchanged files (122)
Total files change +9.01KB +1.71% Final result: ✅ View report in BundleMon website ➡️ |
Contributor
|
Documentation Preview: https://kit-docs-4t3ristse-anza-tech.vercel.app |
mcintyre94
force-pushed
the
react/use-tracked-data-swr
branch
from
948f9b8 to
3457bd3
Compare
mcintyre94
force-pushed
the
react/use-subscription-swr
branch
from
f3f39e1 to
7f08fc4
Compare
mcintyre94
force-pushed
the
react/use-tracked-data-swr
branch
from
3457bd3 to
b7e063e
Compare
mcintyre94
force-pushed
the
react/use-subscription-swr
branch
from
7f08fc4 to
948efe9
Compare
mcintyre94
force-pushed
the
react/use-tracked-data-swr
branch
from
b7e063e to
3a03ef4
Compare
mcintyre94
force-pushed
the
react/use-subscription-swr
branch
from
948efe9 to
603b8f5
Compare
mcintyre94
force-pushed
the
react/use-tracked-data-swr
branch
from
3a03ef4 to
24923d0
Compare
mcintyre94
force-pushed
the
react/use-subscription-swr
branch
from
603b8f5 to
783f65e
Compare
mcintyre94
force-pushed
the
react/use-tracked-data-swr
branch
from
24923d0 to
1eca8d4
Compare
Member
Author
trevor-cortex
left a comment
trevor-cortex
left a comment
There was a problem hiding this comment.
LGTM — would approve if I had the rights to; submitting as a comment review instead.
Adds useTrackedDataSWR — the SWR-backed counterpart to useTrackedData. Wraps createReactiveStoreWithInitialValueAndSlotTracking in useSWRSubscription, bridges getUnifiedState() into next(err, data), ref-syncs the spec and getAbortSignal factory, and uses the established either-null disable pattern (spec == null ? null : key). Ships a thorough browser test suite (loaded/error from both sources, key/spec null transitions, key-change teardown, shared key, abort-signal forwarding, stale-slot dedup, error-after-load retention, stable-key-with-changing-spec, SSR), a typetest, README docs, and a minor changeset.
Structurally a near-mirror of useSubscriptionSWR — same ref-sync, same subscribe-with-empty-deps, same either-null gate, same SSR safety. The only meaningful divergence is the store construction (createReactiveStoreWithInitialValueAndSlotTracking(spec) instead of source.reactiveStore()), which is exactly what the PR description claims. Generics, JSDoc structure, and option merging (SWRConfiguration & UseTrackedDataOptions) all line up with the existing adapters.
Things to watch out for / verify
TErrordefaults tounknownhere (matchinguseSubscriptionSWR), whileuseRequestSWRdefaults toError. Pre-existing inconsistency, not introduced by this PR — flagging only so subsequent reviewers don't waste cycles on it.- Like
useSubscriptionSWR, when the spec identity changes but the SWR key stays stable, the new mappers never take effect (the test "keeps the current store when the spec identity changes but the key is stable" pins this behavior). That's the right call for cache-keyed sharing, but it's a sharp edge for users — calling out below as a doc nit. - Unlike core
useTrackedData, there's norefresh()/reconnect(). PR description explicitly calls this out; the README could mention it too for users coming from the core hook (doc nit below). - StrictMode tolerance is exercised via the latching mocks (
createMockInitialValueSourcereplays the settled outcome to remount dispatches;createMockStreamSourcereplays the log to late subscribers). Worth keeping in mind on any future refactor — these mocks are intentionally shaped to survive the dev double-render, and a naive replacement would surface flakes. - No real network / RPC integration test — the bridge is fully exercised against mocks. That's consistent with the sibling hooks; just noting for future reviewers.
mcintyre94
force-pushed
the
react/use-subscription-swr
branch
from
783f65e to
f835130
Compare
mcintyre94
force-pushed
the
react/use-tracked-data-swr
branch
from
1eca8d4 to
d346a51
Compare
Member
Author
Updated |
mcintyre94
force-pushed
the
react/use-tracked-data-swr
branch
from
d346a51 to
c57c231
Compare
mcintyre94
force-pushed
the
react/use-subscription-swr
branch
from
f835130 to
378f178
Compare
mcintyre94
force-pushed
the
react/use-subscription-swr
branch
from
378f178 to
7491dbe
Compare
mcintyre94
force-pushed
the
react/use-tracked-data-swr
branch
2 times, most recently
from
6e705cf to
f9a0c0c
Compare
mcintyre94
force-pushed
the
react/use-subscription-swr
branch
from
7491dbe to
de50afe
Compare
mcintyre94
force-pushed
the
react/use-tracked-data-swr
branch
from
f9a0c0c to
3739f3c
Compare
mcintyre94
added
the
do-not-close
mcintyre94
force-pushed
the
react/use-subscription-swr
branch
from
de50afe to
d07c735
Compare
mcintyre94
force-pushed
the
react/use-tracked-data-swr
branch
from
3739f3c to
98e12a4
Compare
SWR-backed counterpart to `useTrackedData`. Takes the same `TrackedDataSpec` (RPC fetch + subscription pair + value mappers) and routes the unified, slot-deduped stream through SWR's `useSWRSubscription`, building a fresh `createReactiveStoreWithInitialValueAndSlotTracking` per subscription.
Returns the same `SlotTaggedValue<TItem>` shape that `useSubscriptionSwr` exports — `data.value` is the unified item produced by the spec's mappers; `data.slot` is the envelope's `context.slot`. Mirrors core `useTrackedData`'s top-level `{ data, slot }` flattened into SWR's `data` slot, and matches `useSubscriptionSwr` so a switch between the two SWR hooks is just a different generic, not a different access pattern.
Either `key === null` or `spec === null` disables the subscription, mirroring `useTrackedData`'s nullable-spec pattern. Options merge SWR's config with `useTrackedData`'s `UseTrackedDataOptions` (`getAbortSignal` for per-attempt signals threaded into the underlying store via `withSignal(signal).connect()`).
mcintyre94
force-pushed
the
react/use-subscription-swr
branch
from
d07c735 to
b1c4037
Compare
mcintyre94
force-pushed
the
react/use-tracked-data-swr
branch
from
98e12a4 to
b0480c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR adds
useTrackedDataSWR, the SWR shaped version ofuseTrackedData.As with the other SWR hooks the third param is an
SWRConfiguration, with our usualgetAbortSignalfactory to add a custom signal. It also disables when either key or source are null. Note that SWR subscriptions don't include thereconnectfunction fromuseTrackedData.Note that under the hood this uses
useSWRSubscription, which enables cleaning up the subscription and resetting the store.Note that the issue from
useSubscriptionSWRaround forwarding initial store state does not apply here, because this hook creates its own store combining the two inputs (usingcreateReactiveStoreWithInitialValueAndSlotTrackingfrom Kit).