-
Notifications
You must be signed in to change notification settings - Fork 7
Implement kit-plugin-wallet store, types, and tests #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mcintyre94
wants to merge
36
commits into
main
Choose a base branch
from
wallet-plugin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,717
−31
Open
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
f4407da
Implement kit-plugin-wallet store, types, and tests
mcintyre94 23eb8bc
Add changeset, document in list of plugins
mcintyre94 4a2206d
Address review feedback for wallet plugin
mcintyre94 5f26980
Address second round of review feedback
mcintyre94 bd93e0b
Refactor to use ClientWithPayer and ClientWithIdentity
mcintyre94 67906d9
Cast chain to SolanaChain when creating wallet signer
mcintyre94 7452f21
Address review comments
mcintyre94 47c1cfe
Add abort signal to async wallet actions
mcintyre94 42e7887
Fix lint
mcintyre94 c2d9aac
Refine selectAccount, persistence, and concurrency edge cases
mcintyre94 2ef7dde
Update package.json scripts to match other plugins
mcintyre94 d509997
Bump to Kit 6.9.0, use new SolanaError codes
mcintyre94 05cf269
Rename deprecated imports from wallet-standard/ui-registry
mcintyre94 ce19a0b
Remove now unneeded cast from createSignerFromWalletAccount call
mcintyre94 2289e15
fixup! Rename deprecated imports from wallet-standard/ui-registry
mcintyre94 f5db399
Handle missing signIn feature + no-op wallet change events
mcintyre94 c96d700
fix disconnect during auto-reconnect
mcintyre94 3897f70
Handle error from reading localStorage global
mcintyre94 3b8cfca
Improve handling of wallet unregistering
mcintyre94 8968e65
Better handle reverting to previous connection when a connect fails
mcintyre94 2796903
Resolve signMessage against the account, not the wallet
mcintyre94 d2f705f
Avoid re-rendering if the filtered wallet list is unchanged after un/…
mcintyre94 d6e3094
Throw if connect/signIn becomes unavailable/does not succeed
mcintyre94 3682d1a
Improve test coverage
mcintyre94 b2ebcdd
Avoid auto-connect after store is disposed
mcintyre94 74e9298
Fix disconnect not superseding an inflight connect/signIn
mcintyre94 272fc0e
Reconcile wallet list inn change events
mcintyre94 4446a5d
Move @wallet-standard/errors to dev dependency
mcintyre94 1a3865a
Make SSR no-op use rejected promises
mcintyre94 9986851
nit updates
mcintyre94 375496f
Protect against reconnecting to a disconnecting wallet
mcintyre94 13a5140
Bump connect generation in selectAccount
mcintyre94 3d04a58
Resolve connect feature at the start of connect
mcintyre94 079bd44
Persist in attemptSilentReconnect if address has changed
mcintyre94 a6e8c3b
Docblock nits
mcintyre94 0a1f210
Fix race conditions in selectAccount
mcintyre94 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@solana/kit-plugin-wallet': minor | ||
| --- | ||
|
|
||
| Add `walletSigner`, `walletIdentity`, `walletPayer`, and `walletWithoutSigner` plugins for framework-agnostic wallet management using wallet-standard. Provides wallet discovery, connection lifecycle, signer creation, auto-connect persistence, subscribable state for UI frameworks, and dynamic payer/identity integration. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: make this changeset more of a new plugin announcement, with code examples