Skip to content

feat(secureservice): add admission primitives#680

Open
ZanzyTHEbar wants to merge 1 commit into
anyproto:mainfrom
ZanzyTHEbar:federated-admission-primitives
Open

feat(secureservice): add admission primitives#680
ZanzyTHEbar wants to merge 1 commit into
anyproto:mainfrom
ZanzyTHEbar:federated-admission-primitives

Conversation

@ZanzyTHEbar

Copy link
Copy Markdown

Summary

  • Add provider-neutral admission primitives to secureservice for future federated network admission support.
  • Add disabled-by-default secure.admission config fields and defaults for issuer/audience/JWKS/claims/identity binding metadata.
  • Add a no-op verifier and focused tests without changing handshake behavior.

Rationale

This is the first small, reviewable slice toward generic federated admission control for self-hosted Any-Sync networks. It intentionally avoids provider-specific assumptions and does not wire admission into runtime authentication yet.

Security

  • No authentication behavior changes in this PR.
  • Admission is disabled by default.
  • No secrets or provider-specific configuration are introduced.
  • Future PRs can implement JWT/JWKS verification behind the new AdmissionVerifier interface.

Validation

  • PASS: go test ./net/secureservice
  • PASS: go test ./net/secureservice/handshake
  • PASS: go test ./... -run '^$'
  • KNOWN UNRELATED FAILURE: go test ./... fails in github.com/anyproto/any-sync/net/rpc/limiter at TestLimiter_Concurrent_Bursts; rerunning go test ./net/rpc/limiter reproduces the same threshold failure.

Introduce provider-neutral admission config and verifier types for future federated network admission support. The new config is disabled by default and does not change handshake behavior.
@github-actions

github-actions Bot commented May 20, 2026

Copy link
Copy Markdown

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ZanzyTHEbar

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@ZanzyTHEbar

Copy link
Copy Markdown
Author

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant