Repository navigation
Add progress bars to benchmark script - #72
Merged
Merged
Conversation
running benchmark especially with large files can take a long time, progress bar will help there.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Timed polling distorts benchmark results, and the size progress bar uses an inaccurate unit.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds nested progress reporting to the benchmark workflow.
Changes:
- Shows generation, run, size, and optional copy-byte progress.
- Adds thread-safe copy progress tracking.
- Adds
tqdmdevelopment dependencies.
| File | Description |
|---|---|
benchmark.py |
Implements progress bars and tracking. |
pyproject.toml |
Adds progress-bar dependencies. |
uv.lock |
Locks new dependencies. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Running benchmark especially with large files can take a long time, progress bar will help there.