json: parse quoted integers exactly#255
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parse quoted integer strings exactly in the JSON helpers instead of routing decimal/exponent forms through
f64.Why
parse_int_from_strwas exact for plain integer strings, but strings like"1e5"or"9007199254740993.0"fell back tof64. That meant values above the2^53precision boundary could be silently rounded during JSON decode.What changed
f64fallback with an exact decimal/scientific parser for quoted integer strings"1200e-2"2^53boundary cases,u64::MAXwith.0, and non-integral exponent stringsValidation
cargo test -p buffa