descriptor: validate reflective field membership#254
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add checked reflective mutation APIs that validate field-descriptor membership before mutating a
DynamicMessage.Why
ReflectMessageMut::setandclearwere accepting anyFieldDescriptorand indexing directly by field number. If a caller passed a descriptor from another message or another pool with the same number, the dynamic message could silently mutate the wrong field in release builds.What changed
ReflectErrorplus checkedtry_setandtry_clearonReflectMessageMutDynamicMessagebefore mutating statesetandclearpaths panic on foreign descriptors instead of silently mutating a colliding field numberhasfor parity withgetandfield_mutCompatibility
I kept the existing
setandclearsignatures intact to avoid a trait break. Callers that want recoverable errors can switch totry_setandtry_clear.Validation
cargo test -p buffa-descriptor --features reflect