fix(sessions): settle interrupted tool calls#395
Open
rluisr wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #393.
Summary
Prevent
SessionToolRunnerfrom repeatedly dispatching tool calls invalidated by a processed session-wideuser.interrupt.processed_at, rather than relying oncreated_atlist orderSession event history is sorted by
created_at. Because a queued user interrupt receivesprocessed_atlater, an invalidated tool call can appear after the interrupt in listed history. The runner therefore stores each tool call's processing timestamp and applies the latest processed global interrupt as a cutoff.The history refresh on permanent 4xx only runs on the exceptional path. It records all tool results and the latest processed global interrupt before deciding whether the rejected call was settled elsewhere.
The empty-output 400 described in #377 is independent and is handled separately in #394.
Verification
go test -count=1 -run '^(TestSessionToolRunner_|TestIdleClock_)' .go test -race -count=1 -run '^(TestSessionToolRunner_|TestIdleClock_)' .go test -count=50 -run 'TestSessionToolRunner_(GlobalInterrupt|PermanentRejectionRefreshesSettlementHistory|ExternalResultReleasesConfirmationHold|DrainsRejectedCall|SurfaceCall)' ../scripts/lintgo vet . ./tools/agenttoolsetgit diff --check