feat: [Remote rendering 3.3b] fold per-part edge visibility into the global toggle - #138
Open
LKasianAnsys wants to merge 2 commits into
Conversation
LKasianAnsys
changed the base branch from
main
to
feat/3.3a-server-tracked-widget-toggles
September 22, 2026 22:12
LKasianAnsys
force-pushed
the
feat/3.3b-fold-edge-visibility-into-global-toggle
branch
from
September 23, 2026 22:53
445008b to
b10db12
Compare
LKasianAnsys
marked this pull request as ready for review
September 23, 2026 23:00
LKasianAnsys
force-pushed
the
feat/3.3b-fold-edge-visibility-into-global-toggle
branch
from
September 24, 2026 18:05
b10db12 to
da48fb9
Compare
LKasianAnsys
force-pushed
the
feat/3.3b-fold-edge-visibility-into-global-toggle
branch
from
September 24, 2026 18:12
da48fb9 to
93267a1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Addresses #21
Context
This is the second PR of 4 to move ownership of widget state from the client to the server.
The wire frame widget requires the individual parts to toggle their edge visibility on or off, according to a single global toggle. VISOR does not support per-part controls for the edge visibilty, only a global setting that turns all parts on or off for the scene.
The individual parts currently have an edge visibility property stored as state, but this is not actually needed as we only ever toggle them on or off for the whole scene.
This PR is purely a cleanup: the per-part edge surface had no live caller, so the edge visibility application now happens in the edges widget itself.
Manual testing
No observable behaviour change is expected
Copilot summary
This pull request refactors how edge (wireframe) visibility is managed in the remote rendering system. Previously, edge visibility could be toggled per-part; this logic is now consolidated into a single global toggle, simplifying both the backend and frontend code. The change removes per-part edge visibility state and methods, updates the widget logic, and improves test coverage to ensure correct behavior.
Edge Visibility Refactor:
apply_edge_visibilityand related logic inbase.py,local_renderer.py,null_renderer.py). Edge visibility is now managed globally. [1] [2] [3]edgeVisibilityproperty,setEdgeVisibilityAsyncmethod, and related internal state inVisorSceneGraph.tsx). [1] [2] [3] [4] [5]Frontend/Widget Changes:
EdgesWidgetto enumerate all actor nodes and call the renderer’s per-actorsetEdgeVisibilityAsyncfor each, using the global toggle state. The widget now receives the renderer as a dependency. [1] [2] [3]Testing Improvements:
Documentation/Changelog:
Cleanup:
These changes streamline edge visibility management, reduce code complexity, and ensure consistent behavior across the application.