Skip to content

Add ManualStorageSegment for direct HTTP integration with Segment ana…#398

Draft
cshiels-ie wants to merge 1 commit into
develfrom
segment-send
Draft

Add ManualStorageSegment for direct HTTP integration with Segment ana…#398
cshiels-ie wants to merge 1 commit into
develfrom
segment-send

Conversation

@cshiels-ie

Copy link
Copy Markdown
Contributor

…lytics

This new class implements a direct HTTP storage backend for Segment, bypassing the segment-analytics-python library to prevent issues with oversized POST requests. Key features include unique message IDs and timestamps for each chunk to avoid deduplication, and improved error handling for HTTP responses. The implementation retains chunking behavior from the existing StorageSegment class while enhancing reliability in event delivery.

[AAP-XXXXX]
Dont forget to link back issue to PR.

Description

  • What is being changed?
  • Why is this change needed?
  • How does this change address the issue?

Testing

Prerequisites

Steps to Test

Expected Results

Required Actions

  • Requires documentation updates
  • Requires downstream repository changes
  • Requires infrastructure/deployment changes
  • Requires coordination with other teams
  • Blocked by PR/MR: #XXX

Self-Review Checklist

Code Quality

  • Code is properly linted and formatted.
  • All tests (existing and new) pass successfully.
  • Tests are added or updated as needed.
  • Code includes relevant comments for complex sections.
  • Changes are reviewed and approved by at least two team members.
  • Documentation is updated where applicable.
    - If updates are required in the handbook, create a separate PR for the handbook repo.

Notes for Reviewers

Add any additional context or instructions for reviewers here - for example screenshots if needed.

…lytics

This new class implements a direct HTTP storage backend for Segment, bypassing the segment-analytics-python library to prevent issues with oversized POST requests. Key features include unique message IDs and timestamps for each chunk to avoid deduplication, and improved error handling for HTTP responses. The implementation retains chunking behavior from the existing StorageSegment class while enhancing reliability in event delivery.
@coderabbitai

coderabbitai Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a4b0b72a-870d-4545-81de-c816b4f2302a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch segment-send

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

sonarqubecloud Bot commented May 8, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
9.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant