Skip to content

sonar issues: Refactor functions with high complexity #1607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcraiglo1 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

sonar issues: Refactor functions with high complexity #1607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ebff14b
sonar issues: Refactor functions with high complexity
jcraiglo1 Jun 24, 2026
4782b35
sonar issues: Refactor functions with high complexity
jcraiglo1 Jun 25, 2026
8c1bee4
sonar issues: Refactor functions with high complexity
jcraiglo1 Jun 25, 2026
4f28915
sonar issues: Refactor functions with high complexity
jcraiglo1 Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/aap_eda/api/metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def _customize_field_attributes(method: str, action: dict):
action.pop(field)

# For PUT/PATCH/POST methods, remove read-only fields.
if method in ("PUT", "PATCH", "POST"):
elif method in ("PUT", "PATCH", "POST"):
# file-based read-only settings can't be updated
meta.pop("defined_in_file", False)

Expand Down
44 changes: 23 additions & 21 deletions src/aap_eda/api/views/root.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,32 +52,34 @@ def get(self, request, *args, **kwargs):
return Response(urls)


def _list_urls(url_patterns, request=None):
"""Collect named URL patterns into a dict of name to URL."""
url_list = {}
for url in url_patterns:
if isinstance(url, URLResolver):
url_list.update(_list_urls(url.url_patterns, request))
elif isinstance(url, URLPattern):
name = url.name
if not name:
LOGGER.warning(
"URL %s has no name, DRF browsable API will omit it",
url.pattern,
)
continue
if url.pattern.regex.groups:
continue
url_list[name] = reverse(name, request=request)
return url_list


def get_api_v1_urls(request=None):
from aap_eda.api import urls

def list_urls(urls):
url_list = {}
for url in urls:
if isinstance(url, URLResolver):
url_list.update(list_urls(url.url_patterns))
elif isinstance(url, URLPattern):
name = url.name
if not name:
LOGGER.warning(
"URL %s has no name, DRF browsable API will omit it",
url.pattern,
)
continue
if url.pattern.regex.groups:
continue
url_list[name] = reverse(name, request=request)
return url_list

if settings.ALLOW_LOCAL_RESOURCE_MANAGEMENT:
return list_urls(urls.v1_urls)
return _list_urls(urls.v1_urls, request)

url_list = list_urls(urls.eda_v1_urls)
all_urls = list_urls(urls.dab_urls)
url_list = _list_urls(urls.eda_v1_urls, request)
all_urls = _list_urls(urls.dab_urls, request)
for name, url in all_urls.items():
if name in ALWAYS_VISIBLE_ENDPOINTS:
url_list[name] = url
Expand Down
284 changes: 147 additions & 137 deletions src/aap_eda/core/management/commands/create_initial_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2655,150 +2655,160 @@ def _create_obj_roles(self):
for cls in permission_registry.all_registered_models:
ct = self.content_type_model.objects.get_for_model(cls)
parent_model = permission_registry.get_parent_model(cls)
# ignore if the model is organization, covered by org roles
# or child model, inherits permissions from parent model
# ignore if the model is organization, covered by org
# roles or child model, inherits permissions from
# parent model
if cls._meta.model_name == "organization" or (
parent_model
and parent_model._meta.model_name != "organization"
):
continue
permissions = self._create_permissions_for_content_type(ct)
desc = f"Has all permissions to a single {cls._meta.verbose_name}"
# parent model should add permissions related to its child models
child_models = permission_registry.get_child_models(cls)
child_names = []
for _, child_model in child_models:
child_ct = self.content_type_model.objects.get_for_model(
child_model
)
permissions.extend(
self._create_permissions_for_content_type(child_ct)
)
child_names.append(child_model._meta.verbose_name)
if child_names:
desc += f" and its child resources - {', '.join(child_names)}" # noqa: E501

# create resource admin role
admin_role_name = f"{cls._meta.verbose_name.title()} Admin"
if cls._meta.model_name == "project":
admin_role_name = f"EDA {admin_role_name}"
elif cls._meta.model_name == "edacredential":
admin_role_name = admin_role_name.replace("Eda ", "EDA ")

role, created = RoleDefinition.objects.update_or_create(
name=admin_role_name,
defaults={
"description": desc,
"content_type": ct,
"managed": True,
},
)
role.permissions.set(permissions)
if created:
self.stdout.write(
f"Added role {role.name} with {len(permissions)} "
"permissions to itself"
)

# create resource use role
# ignore team model as it makes no sense to have Use role for it
# and should be managed by Admin users only
if cls._meta.model_name != "team":
use_role_name = f"{cls._meta.verbose_name.title()} Use"
if cls._meta.model_name == "project":
use_role_name = f"EDA {use_role_name}"
elif cls._meta.model_name == "edacredential":
use_role_name = use_role_name.replace("Eda ", "EDA ")

(
use_role,
use_role_created,
) = RoleDefinition.objects.update_or_create(
name=use_role_name,
defaults={
"description": f"Has use permissions to a single {cls._meta.verbose_name}", # noqa: E501
"content_type": ct,
"managed": True,
},
)
use_permissions = [
perm
for perm in permissions
if perm.codename.startswith("view_")
]
use_role.permissions.set(use_permissions)
if use_role_created:
self.stdout.write(
f"Added role {use_role.name} with "
f"{len(use_permissions)} permissions to itself"
)
permissions = self._collect_permissions(cls, ct)
desc = self._build_admin_description(cls)
self._create_admin_role(cls, ct, permissions, desc)

# create org-level admin roles for each resource type
org_role_name = (
f"Organization {cls._meta.verbose_name.title()} Admin"
)
if cls._meta.model_name == "project":
org_role_name = f"EDA {org_role_name}"
elif cls._meta.model_name == "edacredential":
org_role_name = org_role_name.replace("Eda ", "EDA ")

(
org_role,
org_role_created,
) = RoleDefinition.objects.update_or_create(
name=org_role_name,
defaults={
"description": f"Has all permissions to {cls._meta.verbose_name}s within an organization", # noqa: E501
"content_type": self.content_type_model.objects.get(
model="organization"
),
"managed": True,
},
)
permissions.extend(
DABPermission.objects.filter(
content_type=ct, codename__startswith="add_"
)
)
# Add organization view permission for organization-level admin roles, # noqa: E501
org_ct = self.content_type_model.objects.get(
model="organization"
)
org_view_permission = DABPermission.objects.filter(
content_type=org_ct, codename="view_organization"
).first()
if (
org_view_permission
and org_view_permission not in permissions
):
permissions.append(org_view_permission)

org_role.permissions.set(permissions)
if org_role_created:
self.stdout.write(
f"Added role {org_role.name} with {len(permissions)} "
"permissions to itself"
)
# ignore team model as it makes no sense to have Use
# role for it and should be managed by Admin users only
if cls._meta.model_name != "team":
self._create_use_role(cls, ct, permissions)
self._create_org_admin_role(cls, ct, permissions)

# Special case to create team member role
if cls._meta.model_name == "team":
member_permissions = [
p
for p in permissions
if p.codename in ("view_team", "member_team")
]
desc = "Inherits permissions assigned to this team"
role, created = RoleDefinition.objects.update_or_create(
name="Team Member",
defaults={
"description": desc,
"content_type": ct,
"managed": True,
},
)
role.permissions.set(member_permissions)
if created:
self.stdout.write(
f"Added role {role.name} with "
f"{len(member_permissions)} permissions to itself"
)
self._create_team_member_role(ct, permissions)

def _collect_permissions(self, cls, ct):
"""Gather permissions for a model including child models."""
permissions = self._create_permissions_for_content_type(ct)
# parent model should add permissions related to its
# child models
for _, child_model in permission_registry.get_child_models(cls):
child_ct = self.content_type_model.objects.get_for_model(
child_model
)
permissions.extend(
self._create_permissions_for_content_type(child_ct)
)
return permissions

def _build_admin_description(self, cls):
"""Build the admin role description with child resources."""
desc = "Has all permissions to a single " f"{cls._meta.verbose_name}"
child_names = [
cm._meta.verbose_name
for _, cm in permission_registry.get_child_models(cls)
]
if child_names:
desc += " and its child resources" f" - {', '.join(child_names)}"
return desc

def _format_role_name(self, cls, template):
"""Format a role name with EDA prefix for special models."""
name = template.format(verbose=cls._meta.verbose_name.title())
if cls._meta.model_name == "project":
name = f"EDA {name}"
elif cls._meta.model_name == "edacredential":
name = name.replace("Eda ", "EDA ")
return name

def _create_admin_role(self, cls, ct, permissions, desc):
"""Create resource admin role."""
name = self._format_role_name(cls, "{verbose} Admin")
role, created = RoleDefinition.objects.update_or_create(
name=name,
defaults={
"description": desc,
"content_type": ct,
"managed": True,
},
)
role.permissions.set(permissions)
if created:
self.stdout.write(
f"Added role {role.name} with "
f"{len(permissions)} permissions to itself"
)

def _create_use_role(self, cls, ct, permissions):
"""Create resource use role (view-only permissions)."""
name = self._format_role_name(cls, "{verbose} Use")
use_role, created = RoleDefinition.objects.update_or_create(
name=name,
defaults={
"description": (
"Has use permissions to a single "
f"{cls._meta.verbose_name}"
),
"content_type": ct,
"managed": True,
},
)
use_permissions = [
p for p in permissions if p.codename.startswith("view_")
]
use_role.permissions.set(use_permissions)
if created:
self.stdout.write(
f"Added role {use_role.name} with "
f"{len(use_permissions)} permissions to itself"
)

def _create_org_admin_role(self, cls, ct, permissions):
"""Create org-level admin role for a resource type."""
name = self._format_role_name(cls, "Organization {verbose} Admin")
org_ct = self.content_type_model.objects.get(model="organization")
org_role, created = RoleDefinition.objects.update_or_create(
name=name,
defaults={
"description": (
"Has all permissions to "
f"{cls._meta.verbose_name}s "
"within an organization"
),
"content_type": org_ct,
"managed": True,
},
)
permissions.extend(
DABPermission.objects.filter(
content_type=ct, codename__startswith="add_"
)
)
# Add organization view permission for
# organization-level admin roles
org_view_permission = DABPermission.objects.filter(
content_type=org_ct, codename="view_organization"
).first()
if org_view_permission and org_view_permission not in permissions:
permissions.append(org_view_permission)

org_role.permissions.set(permissions)
if created:
self.stdout.write(
f"Added role {org_role.name} with "
f"{len(permissions)} permissions to itself"
)

def _create_team_member_role(self, ct, permissions):
"""Create team member role."""
member_permissions = [
p
for p in permissions
if p.codename in ("view_team", "member_team")
]
role, created = RoleDefinition.objects.update_or_create(
name="Team Member",
defaults={
"description": ("Inherits permissions assigned to this team"),
"content_type": ct,
"managed": True,
},
)
role.permissions.set(member_permissions)
if created:
self.stdout.write(
f"Added role {role.name} with "
f"{len(member_permissions)} "
"permissions to itself"
)
Loading
Loading