fix: increase wait() timeout for multi-message consumer tests#1551
fix: increase wait() timeout for multi-message consumer tests#1551B-Whitt wants to merge 1 commit into
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughIntegration tests in the WebSocket consumer module add timeout constraints to synchronization waits by replacing bare ChangesWebSocket Wait Timeout Additions
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1551 +/- ##
=======================================
Coverage 91.99% 91.99%
=======================================
Files 241 241
Lines 10958 10958
=======================================
Hits 10081 10081
Misses 877 877
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
9c591d8 to
552c3bd
Compare
|
/run-e2e |
Tests that send multiple websocket messages before calling wait() can flake under CI load because the default 1-second timeout cancels the consumer task before all messages are processed. Add explicit timeout=TIMEOUT (5s) to the 5 multi-message tests only, matching the pattern already used for receive_json_from() in the same file. Single-message tests keep the default for fast failure detection. Assisted-by: Claude Opus
552c3bd to
1b79d75
Compare
|
|
@B-Whitt would you please link logs of jobs that fail, and would be fixed by this? nothing potentially wrong with this, I simply want to check what is the issue supposed to be fixed thanks! |



Summary
wait()can flake under CI load — the default 1-second timeout cancels the consumer task before all messages are processedtest_multiple_rules_for_one_eventwas observed failing withassert 1 == 2because only one of two actions was processed within the 1s windowtimeout=TIMEOUT(5s) to the 5 multi-message tests only, matching the pattern already used forreceive_json_from(timeout=TIMEOUT)in the same fileTest plan
test_multiple_rules_for_one_eventpasses locallytest_consumer.pypass (72s)🤖 Assisted by Claude Opus