Skip to content

remove: Remove deprecated reference to manager_auth_proxy_patch.yaml#350

Merged
ptoscano merged 1 commit into
ansible:mainfrom
Francisco-xiq:fix/deprecated-manager-auth-proxy-reference
May 29, 2026
Merged

remove: Remove deprecated reference to manager_auth_proxy_patch.yaml#350
ptoscano merged 1 commit into
ansible:mainfrom
Francisco-xiq:fix/deprecated-manager-auth-proxy-reference

Conversation

@Francisco-xiq

@Francisco-xiq Francisco-xiq commented May 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Removes a stale reference to ../default/manager_auth_proxy_patch.yaml in config/testing/kustomization.yaml.

This file was deleted in #323 but the reference was left behind, causing kustomize build to fail for anyone using the config/testing directory.

Closes #262

Changes

  • config/testing/kustomization.yaml: removed path entry pointing to deleted file ../default/manager_auth_proxy_patch.yaml

Note

make lint was already failing before this change on roles/postgres/ and roles/restore/.

Summary by CodeRabbit

  • Chores
    • Updated testing environment configuration to switch manager image reference and enable more verbose debug logging during tests.
    • Removed an obsolete proxy patch to streamline test setup and improve configuration consistency.

@coderabbitai

coderabbitai Bot commented May 27, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 7ac0c5ee-65f4-4803-a227-2552a3755e45

📥 Commits

Reviewing files that changed from the base of the PR and between 3e7d3f1 and 746a39d.

📒 Files selected for processing (1)
  • config/testing/kustomization.yaml
💤 Files with no reviewable changes (1)
  • config/testing/kustomization.yaml

📝 Walkthrough

Walkthrough

Update testing Kustomize to remove the default manager auth-proxy patch and add two test-specific patches: manager_image.yaml and debug_logs_patch.yaml. No other fields (namespace, namePrefix, resources, images) were changed.

Changes

Testing Kustomize Patch Configuration

Layer / File(s) Summary
Testing environment patch configuration update
config/testing/kustomization.yaml
The patches list is modified to remove ../default/manager_auth_proxy_patch.yaml and add manager_image.yaml and debug_logs_patch.yaml.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR removes a stale file reference but does not address the core objective of issue #262: replacing the deprecated gcr.io/kubebuilder/kube-rbac-proxy image. Verify that the removed patch file was not the only reference to the deprecated kube-rbac-proxy image, and address the image replacement requirement from issue #262.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing a deprecated reference to manager_auth_proxy_patch.yaml from the configuration file.
Out of Scope Changes check ✅ Passed The PR only removes a stale file reference from kustomization.yaml, which is directly related to addressing infrastructure changes mentioned in issue #262.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ttuffin ttuffin requested a review from a team May 28, 2026 06:03
@ttuffin ttuffin enabled auto-merge (squash) May 28, 2026 06:03

@ptoscano ptoscano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

If there is a way to test the configuration in a github workflow, I'd really like to see that, to prevent issues like this.

@ptoscano

Copy link
Copy Markdown
Contributor

@Francisco-xiq thanks for the fix!

Please note that commits to the ansible organization must have signed commits; check the following documentations:
https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits
https://docs.github.com/en/authentication/managing-commit-signature-verification/telling-git-about-your-signing-key

This means you need to amend the current commit to be signed (with either a GPG or a SSH key).

@Francisco-xiq

Copy link
Copy Markdown
Contributor Author

Thanks!

If there is a way to test the configuration in a github workflow, I'd really like to see that, to prevent issues like this.

Thanks for the review.
I guess thats totally possible, gonna start working on a design.

auto-merge was automatically disabled May 28, 2026 16:41

Head branch was pushed to by a user without write access

@Francisco-xiq Francisco-xiq force-pushed the fix/deprecated-manager-auth-proxy-reference branch from 3e7d3f1 to 746a39d Compare May 28, 2026 16:41
@sonarqubecloud

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Actionable comments posted: 0

@Francisco-xiq

Copy link
Copy Markdown
Contributor Author

Thanks!

If there is a way to test the configuration in a github workflow, I'd really like to see that, to prevent issues like this.

I think the main issue is that the configuration points to a non-existent file. If we add a CI step to verify the build before running the tests, it would make debugging much easier (and save us from waiting for the heavier tests to fail).

So, I suggest adding a quick check to the Kustomize build to ensure it runs smoothly and that all paths in the file actually exist. If everything looks good, then we are ok to run the Minikube tests. WDYT?

@ptoscano

Copy link
Copy Markdown
Contributor

So, I suggest adding a quick check to the Kustomize build to ensure it runs smoothly and that all paths in the file actually exist. If everything looks good, then we are ok to run the Minikube tests. WDYT?

If that can be run easily in a github workflow, sure, it makes sense. Feel free to open a new PR for it.

(note you need to still upload your key to your profile)

@ptoscano ptoscano merged commit 27522e9 into ansible:main May 29, 2026
7 checks passed
@Francisco-xiq Francisco-xiq deleted the fix/deprecated-manager-auth-proxy-reference branch June 1, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

⚠️ Action Required: Replace Deprecated gcr.io/kubebuilder/kube-rbac-proxy

3 participants