remove: Remove deprecated reference to manager_auth_proxy_patch.yaml#350
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughUpdate testing Kustomize to remove the default manager auth-proxy patch and add two test-specific patches: ChangesTesting Kustomize Patch Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ptoscano
left a comment
There was a problem hiding this comment.
Thanks!
If there is a way to test the configuration in a github workflow, I'd really like to see that, to prevent issues like this.
|
@Francisco-xiq thanks for the fix! Please note that commits to the This means you need to amend the current commit to be signed (with either a GPG or a SSH key). |
Thanks for the review. |
Head branch was pushed to by a user without write access
3e7d3f1 to
746a39d
Compare
|
|
Actionable comments posted: 0 |
I think the main issue is that the configuration points to a non-existent file. If we add a CI step to verify the build before running the tests, it would make debugging much easier (and save us from waiting for the heavier tests to fail). So, I suggest adding a quick check to the Kustomize build to ensure it runs smoothly and that all paths in the file actually exist. If everything looks good, then we are ok to run the Minikube tests. WDYT? |
If that can be run easily in a github workflow, sure, it makes sense. Feel free to open a new PR for it. (note you need to still upload your key to your profile) |



Summary
Removes a stale reference to
../default/manager_auth_proxy_patch.yamlinconfig/testing/kustomization.yaml.This file was deleted in #323 but the reference was left behind, causing
kustomize buildto fail for anyone using theconfig/testingdirectory.Closes #262
Changes
config/testing/kustomization.yaml: removed path entry pointing to deleted file../default/manager_auth_proxy_patch.yamlNote
make lintwas already failing before this change onroles/postgres/androles/restore/.Summary by CodeRabbit