Skip to content

Refactor: delete unused media button#21362

Merged
criticalAY merged 1 commit into
ankidroid:mainfrom
amoniaka-knabino:fix-20508-delete-unused-media-button
Jul 10, 2026
Merged

Refactor: delete unused media button#21362
criticalAY merged 1 commit into
ankidroid:mainfrom
amoniaka-knabino:fix-20508-delete-unused-media-button

Conversation

@amoniaka-knabino

@amoniaka-knabino amoniaka-knabino commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Purpose / Description

Change OK button to Delete button on "Delete unused media?" dialog window.

Fixes

Approach

More easy to understand button meaning

How Has This Been Tested?

Commit tests + UI check.

Learning (optional, can help others)

Describe the research stage

Links to blog posts, patterns, libraries or addons used to solve this problem

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@welcome

This comment was marked as spam.

@amoniaka-knabino

Copy link
Copy Markdown
Contributor Author

Before
telegram-cloud-photo-size-2-5368452667962758486-y
After
telegram-cloud-photo-size-2-5368452667962758487-y

@amoniaka-knabino
amoniaka-knabino marked this pull request as ready for review July 10, 2026 03:38

@criticalAY criticalAY left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Here is something to learn @amoniaka-knabino : Fixes # would close the issue where as we are just trying to resolve a part of it (updated the description) and it would be good if we can learn rebase

@criticalAY criticalAY added the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jul 10, 2026
@criticalAY
criticalAY added this pull request to the merge queue Jul 10, 2026
@criticalAY
criticalAY removed this pull request from the merge queue due to a manual request Jul 10, 2026
@criticalAY
criticalAY force-pushed the fix-20508-delete-unused-media-button branch from 6b1a0f4 to f611f8b Compare July 10, 2026 07:54
@criticalAY
criticalAY enabled auto-merge July 10, 2026 07:54
@criticalAY criticalAY changed the title Fix 20508 delete unused media button Refactor: delete unused media button Jul 10, 2026
@criticalAY
criticalAY added this pull request to the merge queue Jul 10, 2026
Merged via the queue into ankidroid:main with commit ea1d460 Jul 10, 2026
20 checks passed
@github-actions github-actions Bot added this to the 2.25 release milestone Jul 10, 2026
@github-actions github-actions Bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants