read Svg preview off the main Thread#21344
Merged
Merged
Conversation
sanjaysargam
requested changes
Jul 12, 2026
sanjaysargam
left a comment
sanjaysargam
left a comment
Member
There was a problem hiding this comment.
Thanks for contributing @Phoenix1808 🚀
| Timber.w("Failed to load SVG from URI") | ||
| showErrorInWebView() | ||
| val webView = this | ||
| lifecycleScope.launch { |
Member
There was a problem hiding this comment.
I'd use viewLifecycleOwner.lifecycleScope
This ensures coroutine is cancelled if view is destroyed, preventing potential crashes
| showErrorInWebView() | ||
| val webView = this | ||
| lifecycleScope.launch { | ||
| val svgData = withContext(Dispatchers.IO) { loadSvgFromUri(imageUri) } |
Member
There was a problem hiding this comment.
try/catch would be even more better
Contributor
Author
|
Done, Please have a look! @sanjaysargam |
sanjaysargam
approved these changes
Jul 12, 2026
sanjaysargam
added
Needs Second Approval
lukstbit
approved these changes
Jul 13, 2026
lukstbit
left a comment
lukstbit
left a comment
Member
There was a problem hiding this comment.
Looks good, pending on the comment below. Thanks!
lukstbit
added
Needs Author Reply
Member
|
@Phoenix1808 Could you please squash commits into one |
Phoenix1808
force-pushed
the
fix/svg_preview_IO
branch
from
July 14, 2026 10:46
70f77e1 to
2c7b63e
Compare
Member
|
Great! |
lukstbit
removed
Needs Author Reply
github-actions
Bot
removed
the
Pending Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
When previewing a selected SVG in the multimedia image editor, the
SVG file is read on the main thread (loadSvgFromUri -> openInputStream
-> convertToString) before it's passed to the WebView. For a large SVG
or a slow document provider, this read can briefly block the UI.
This moves the read to Dispatchers.IO and keeps the WebView update on
the main thread. Behaviour is unchanged.
Fixes #21276
How Has This Been Tested?
Manually previewed SVG and non-SVG images in the multimedia image
editor; the preview renders as before.
:AnkiDroid:compilePlayDebugKotlinbuilds cleanly.
I didn't add an automated test: this is a threading change with no
observable behaviour difference, and there isn't existing infrastructure
to assert main-thread usage here. Happy to add one if you'd prefer a
specific approach.